Skip to content

feat: search input add clear icon #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Jan 26, 2026
Merged

feat: search input add clear icon #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da3cb54
feat: search input add clear icon
btea Jan 26, 2026
476978f
fix: use `<button>` not `<span>` and add aria-label
danielroe Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/pages/search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,11 +370,20 @@ defineOgImageComponent('Default', {
autocomplete="off"
autocorrect="off"
spellcheck="false"
class="w-full max-w-full bg-bg-subtle border border-border rounded-lg pl-8 pr-4 py-3 font-mono text-base text-fg placeholder:text-fg-subtle transition-colors duration-300 focus:(border-border-hover outline-none) appearance-none"
class="w-full max-w-full bg-bg-subtle border border-border rounded-lg pl-8 pr-10 py-3 font-mono text-base text-fg placeholder:text-fg-subtle transition-colors duration-300 focus:(border-border-hover outline-none) appearance-none"
@focus="isSearchFocused = true"
@blur="isSearchFocused = false"
@keydown="handleResultsKeydown"
/>
<button
v-show="inputValue"
type="button"
class="absolute right-3 text-fg-subtle hover:text-fg transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 rounded"
aria-label="Clear search"
@click="inputValue = ''"
Comment thread
btea marked this conversation as resolved.
>
<span class="i-carbon-close-large block w-3.5 h-3.5" aria-hidden="true" />
</button>
<!-- Hidden submit button for accessibility (form must have submit button per WCAG) -->
<button type="submit" class="sr-only">Search</button>
</div>
Expand Down