Skip to content

fix: youtube readme styling#1017

Closed
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:fix/youtube-styling-on-youtube
Closed

fix: youtube readme styling#1017
iiio2 wants to merge 1 commit intonpmx-dev:mainfrom
iiio2:fix/youtube-styling-on-youtube

Conversation

@iiio2
Copy link
Copy Markdown
Contributor

@iiio2 iiio2 commented Feb 5, 2026

resolves #1006

youtube

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 0:45am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 0:45am
npmx-lunaria Ignored Ignored Feb 5, 2026 0:45am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

CSS styling rules have been added to the Readme component to modify the alignment behaviour of HTML elements. Images and containers with align attributes set to 'right' or 'left' now have float properties set to none, and non-image elements receive text-align: start. This adjustment affects how readme content with these alignment attributes is rendered within the application.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description references issue #1006 and includes an image showing the YouTube embed styling problem, which is directly related to the changeset.
Linked Issues check ✅ Passed The code changes add CSS rules to override HTML align attributes on images and containers within readme content, preventing float-based alignment and aligning with GitHub's rendering approach as required by issue #1006.
Out of Scope Changes check ✅ Passed All changes are CSS-only modifications to Readme.vue that directly address the styling issue described in issue #1006, with no unrelated changes introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe
Copy link
Copy Markdown
Member

I think it would be nice if the wrapping persisted/worked

@iiio2
Copy link
Copy Markdown
Contributor Author

iiio2 commented Feb 5, 2026

@danielroe , design like npm is getting very tough for me 😢

@trueberryless
Copy link
Copy Markdown
Contributor

#1040 fixes the issues as well, I think we might close this PR, but @iiio2 feel free to comment on the other PR 👍

@iiio2 iiio2 closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Readme.md YouTube embed incorrect styling.

3 participants