-
-
Notifications
You must be signed in to change notification settings - Fork 424
chore: add e18e lint plugin #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
f28d0ec
6bb7c9d
bee742f
70d80b1
8f52a60
8cf4628
49c95e9
83a644d
7efb507
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,25 @@ | ||
| { | ||
| "$schema": "https://unpkg.com/oxlint/configuration_schema.json", | ||
| "plugins": ["unicorn", "typescript", "oxc", "vue", "vitest"], | ||
| "jsPlugins": ["@e18e/eslint-plugin"], | ||
| "categories": { | ||
| "correctness": "error", | ||
| "suspicious": "warn", | ||
| "perf": "warn" | ||
| }, | ||
| "rules": { | ||
| "no-console": "warn", | ||
| "no-console": "off", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I never understood the purpose of
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we really need to review logging overall. only truly error-level things should be logged at error level, for example. this isn't currently the case iirc i'll start a discussion around this 👍
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would it be possible to disable this just on a per-directory case? so we disable it for server/ and cli/ but keep it for app/ ? |
||
| "no-await-in-loop": "off", | ||
| "unicorn/no-array-sort": "off", | ||
| "no-restricted-globals": "error", | ||
| "typescript/consistent-type-imports": "error" | ||
| "typescript/consistent-type-imports": "error", | ||
| "e18e/prefer-array-from-map": "error", | ||
| "e18e/prefer-timer-args": "error", | ||
| "e18e/prefer-date-now": "error", | ||
| "e18e/prefer-regex-test": "error", | ||
| "e18e/prefer-array-some": "error" | ||
| }, | ||
| "overrides": [], | ||
| "ignorePatterns": [ | ||
| ".output/**", | ||
| ".data/**", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.