feat: add dependents sorted by download#105
Conversation
|
@vinnymac is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| // Use the existing searchNpmPackages with depends-on: query | ||
| // This finds packages that have `name` as a dependency | ||
| const response = await searchNpmPackages(`depends-on:${name}`, { size }) |
There was a problem hiding this comment.
I'm not sure this pulls in correct data:
There was a problem hiding this comment.
in e18e we have a whole other database to do this query because the npm one wasn't capable. so when i saw this, i was very surprised and hoped it was true so we could switch 😂
but im pretty sure the npm api doesn't do what you think here, or it does, but very poorly
There was a problem hiding this comment.
Darn, back to the drawing board! Thought the data was correct 🥲
There was a problem hiding this comment.
how about this one https://www.npmjs.com/browse/depended/nuxt ?
Note: The data from /registry is stale currently, but is being refreshed. Work to add download counts to /live_registry is in progress.
|
Is this PR still relevant given it was open two weeks ago and a lot has changed since? |
|
im going to close it since the search has drastically changed under the hood, and we were already blocked by this thread. @vinnymac lets revisit this later once we have a better idea of how to query this stuff |
6 participants
Adds dependents to package page sorted by most downloaded (top 50)
Closes #31