Skip to content

chore: resolve broken alert rendering in nested list #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Feb 6, 2026
Merged

chore: resolve broken alert rendering in nested list #1065

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0095070
chore: resolve broken alert rendering in nested list
RYGRIT Feb 6, 2026
8c46201
chore: add warning icon
RYGRIT Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ To add a new locale:
cp i18n/locales/uk-UA.json lunaria/files/uk-UA.json
```

> [!IMPORTANT]
> **Important:**
Copy link
Copy Markdown
Contributor

@carwack carwack Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help to be even more visible to add an icon in front of it like ⚠️ ?

Copy link
Copy Markdown
Contributor Author

@RYGRIT RYGRIT Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right.

> This file must be committed. Lunaria uses git history to track translation progress, so the build will fail if this file is missing.

5. If the language is `right-to-left`, add `dir: 'rtl'` (see `ar-EG` in config for example)
Expand Down
Loading