Skip to content

fix: add isr to oauth metadata#1090

Closed
alexdln wants to merge 2 commits intonpmx-dev:mainfrom
alexdln:fix/broken-oauth-isr
Closed

fix: add isr to oauth metadata#1090
alexdln wants to merge 2 commits intonpmx-dev:mainfrom
alexdln:fix/broken-oauth-isr

Conversation

@alexdln
Copy link
Copy Markdown
Member

@alexdln alexdln commented Feb 6, 2026

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Error Error Feb 6, 2026 0:45am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 0:45am
npmx-lunaria Ignored Ignored Feb 6, 2026 0:45am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The change modifies the route configuration for the OAuth client metadata endpoint in the Nuxt application. The /oauth-client-metadata.json route rule is updated to include an incremental static regeneration (ISR) setting with a 60-second interval in addition to the existing prerender directive. This combines two caching strategies for the endpoint.

🚥 Pre-merge checks | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request has no description provided by the author, making it impossible to assess whether it relates to the changeset. The author should add a pull request description explaining the purpose of adding ISR configuration to the oauth-client-metadata.json route and why this change is necessary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe closed this Feb 6, 2026
@alexdln alexdln deleted the fix/broken-oauth-isr branch February 6, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants