Skip to content

feat: directly navigate to localized atproto website like https://atproto.com/ja#1136

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
shuuji3:feat/localized-atproto-link
Feb 7, 2026
Merged

feat: directly navigate to localized atproto website like https://atproto.com/ja#1136
danielroe merged 1 commit intonpmx-dev:mainfrom
shuuji3:feat/localized-atproto-link

Conversation

@shuuji3
Copy link
Copy Markdown
Member

@shuuji3 shuuji3 commented Feb 7, 2026

As of today, https://atproto.com supports four languages: English, Japanese, Korean, Portuguese. This allow users (expected to not familiar with atproto) to visit their localized version.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Error Error Feb 7, 2026 8:46am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 7, 2026 8:46am
npmx-lunaria Ignored Ignored Feb 7, 2026 8:46am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the AuthModal component to implement locale-aware AT Protocol link construction. It reads the current locale using useI18n, extracts the language code, and determines a locale sub-path for specific languages (Korean, Portuguese, Japanese) or uses an empty string for others. The static AT Protocol link in the authentication explanation section is replaced with a dynamic link constructed from the locale-specific URL. The sign-in functionality remains unchanged. Package.json is updated with 7 additions and 1 removal.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description accurately describes the changeset, explaining the locale-aware AT Protocol link feature that directs users to localized atproto.com versions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 7, 2026
Merged via the queue into npmx-dev:main with commit 3256342 Feb 7, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants