Skip to content

feat: remove space and @ from user input atproto handle#1137

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:feat/trim-spaces-from-atproto-handle
Feb 7, 2026
Merged

feat: remove space and @ from user input atproto handle#1137
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:feat/trim-spaces-from-atproto-handle

Conversation

@shuuji3
Copy link
Copy Markdown
Member

@shuuji3 shuuji3 commented Feb 7, 2026

This change prevents common mistakes for atproto handle input. Many apps includes @-prefix so users can easily copy their handle with a extra character @ and sometimes spaces in their UI.

Currenctly, I have to strictly input my handle shuuji3.xyz, now I can input @shuuji3.xyz.

Screenshot of auth modal input is ' @shuuji3.xyz '

For reference, this is Bluesky app for @npmx.dev profile:

Screenshot of bluesky profile @npmx.dev including '@' char

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 7, 2026 10:20am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 7, 2026 10:20am
npmx-lunaria Ignored Ignored Feb 7, 2026 10:20am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Header/AuthModal.client.vue 20.00% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about doing the validation at the input level? ie stripping invalid characters directly on paste/type?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Adds a watcher to the login handle input in the client-side auth modal that normalises user-typed handles in real time. Normalisation trims surrounding whitespace, converts to lowercase, and removes any characters other than lowercase letters a–z, digits 0–9, dot (.) and hyphen (-). If the normalised value differs from the original typed value, the input field is updated. No changes were made to login submission behaviour, exported/public APIs, or control flow.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the feature: normalizing atproto handle input by removing spaces and '@' prefixes, with contextual images showing the problem and solution.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment thread app/components/Header/AuthModal.client.vue
@shuuji3
Copy link
Copy Markdown
Member Author

shuuji3 commented Feb 7, 2026

Yeah, that's better approach 👍🏻 I'll update later today.

@shuuji3 shuuji3 force-pushed the feat/trim-spaces-from-atproto-handle branch from 5fa8263 to 393cd83 Compare February 7, 2026 10:19
@shuuji3 shuuji3 marked this pull request as ready for review February 7, 2026 10:20
@shuuji3 shuuji3 requested a review from danielroe February 7, 2026 10:20
@danielroe danielroe added this pull request to the merge queue Feb 7, 2026
Merged via the queue into npmx-dev:main with commit 92f58d8 Feb 7, 2026
17 checks passed
@shuuji3 shuuji3 deleted the feat/trim-spaces-from-atproto-handle branch February 7, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants