feat: adding gh changelog/releases to npmx#1233
feat: adding gh changelog/releases to npmx#1233WilcoSp wants to merge 175 commits intonpmx-dev:mainfrom
Conversation
…md -> html does need to change)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
excludes changelog releases due to needing api calls
escaping title & plain text for changelog md links
43081j
left a comment
43081j
left a comment
There was a problem hiding this comment.
looks good to me!
since its a big change, i'd like to see a 2nd approval before we merge
|
yeah probably a good idea, maybe also an idea is to merge after a release so that this get the maximum amount of time at main.npmx.dev so potential issues can be found, it'll also give translators the time to added text |
|
we're moving more towards a feature schedule rather than a stream of merges going forward, so that'll likely be the case 👍 all good :D |
|
I've just updated the command palette to include changelog & have the package specific commands available at changelog |
| span: prefixId, | ||
| section: prefixId, | ||
| article: prefixId, | ||
| }, |
There was a problem hiding this comment.
It seems to almost completely replicate the logic in utils/readme.ts except for the logic with link collection there. How about create a defaultSanitizeOptions (use this one) and reuse it in both places, but overwrite a there?
There was a problem hiding this comment.
I'm going to save this for the next pr to prevent additional work from merge conflicts that come from potential changes in the utils/readme.ts.
The next planned pr for changelog is meant to make it that more code & logic are going to be shared between utils/readme.ts & utils/changelog/markdown.ts
… be cached for 2 hours while versioned stays 24 hours
…hubIssues & createdAt
|
I've merged main again to this pr branch, but with timeline added the package header menu now looks like this. |
… be nice if someone else updates it properly added small translation for readme error loading
10 participants
This pr will add the possibility to view the changelog.md & releases from a package's github repo within npmx.
This will make it easier to see the changelogs while not needing to leave npmx and allowing quicker access.
This pr is the first pr of #501
Preview here, this will automatically update
Acknowledgements
While I was making this PR antfu also made this pr #1368 and here my comment from his pr
Also @ShroXd is currently working on adding changelogs to the version history page that was merged with #2025, we've both agreed to first independently work on our PRs and later after both are merged and we've received feedback & irl use we'll collaborate on the interaction between the two
Translations
Thanks @WarningImHack3r for translating the text for changelog to French
I've also added Dutch translations