Skip to content

fix: align shell prompt $ for multiple lines command#1313

Merged
whitep4nth3r merged 1 commit intonpmx-dev:mainfrom
shuuji3:fix/install-command-prompt-alignment
Feb 10, 2026
Merged

fix: align shell prompt $ for multiple lines command#1313
whitep4nth3r merged 1 commit intonpmx-dev:mainfrom
shuuji3:fix/install-command-prompt-alignment

Conversation

@shuuji3
Copy link
Copy Markdown
Member

@shuuji3 shuuji3 commented Feb 10, 2026

fix #1311

Before

screenshot of install command, the prompt $ is aligned to the center vertially

After

screenshot of install command, the prompt $ is aligned to the top vertially

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 3:17am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 3:17am
npmx-lunaria Ignored Ignored Feb 10, 2026 3:17am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

This pull request addresses a visual alignment issue in the Terminal Install component. The dollar-sign prefix displayed before shell commands has been updated to use a self-start alignment class across four instances in the code. Previously, the dollar signs used baseline alignment, which caused misalignment when commands spanned multiple lines. The modification is purely a CSS/layout adjustment that changes how the spans containing the dollar signs are positioned vertically, with no alterations to the command generation logic or data flow.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, providing before/after screenshots showing the fix for shell prompt alignment in multi-line commands.
Linked Issues check ✅ Passed The pull request directly addresses issue #1311 by aligning the shell prompt ($) to the top line of multi-line commands through CSS class changes.
Out of Scope Changes check ✅ Passed All changes are scoped to the Install.vue component and consist solely of CSS alignment adjustments directly addressing the linked issue requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
app/components/Terminal/Install.vue (1)

177-177: Consider adding shrink-0 for consistency with the install command prompts.

The $ spans on lines 115 and 142 include the shrink-0 class, but these two do not. For consistency and to prevent the prompt from shrinking if the run/create commands become long enough to cause flex shrinkage, consider adding shrink-0 here as well.

♻️ Suggested diff
-            <span class="self-start text-fg-subtle font-mono text-sm select-none">$</span>
+            <span class="self-start text-fg-subtle font-mono text-sm select-none shrink-0">$</span>

Apply to both lines 177 and 222.

Also applies to: 222-222


Comment @coderabbitai help to get the list of available commands and usage tips.

@whitep4nth3r whitep4nth3r added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit 3c0223b Feb 10, 2026
17 checks passed
@shuuji3 shuuji3 deleted the fix/install-command-prompt-alignment branch February 10, 2026 09:50
@shuuji3
Copy link
Copy Markdown
Member Author

shuuji3 commented Feb 10, 2026

@whitep4nth3r Thanks for reviewings! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell prompt ($) is not aligned for multiple lines command

2 participants