Skip to content

chore: add guidance for screenshots in front end pull requests#1324

Merged
whitep4nth3r merged 2 commits intonpmx-dev:mainfrom
whitep4nth3r:update-contrib
Feb 10, 2026
Merged

chore: add guidance for screenshots in front end pull requests#1324
whitep4nth3r merged 2 commits intonpmx-dev:mainfrom
whitep4nth3r:update-contrib

Conversation

@whitep4nth3r
Copy link
Copy Markdown
Contributor

Also improved wording of using lowercase in pull request descriptions.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Feb 10, 2026 10:17am
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 10:17am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 10, 2026 10:17am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

The changes update the CONTRIBUTING.md file with additional guidance for pull request submissions. The modifications introduce a requirement for frontend-related changes to include before/after screenshots in their pull request descriptions. Additionally, the documentation now emphasises the use of lowercase letters when formatting pull request titles. Minor formatting adjustments have been made to reinforce these guidelines.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is directly related to the changeset, mentioning improvements to lowercase wording in PR descriptions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
CONTRIBUTING.md (1)

792-796: Clarify scope and format for screenshots.

Consider adding a brief note on when screenshots are not needed (e.g., non-visual frontend changes) and a suggested format/location for before/after images to reduce ambiguity.


Comment @coderabbitai help to get the list of available commands and usage tips.

@whitep4nth3r whitep4nth3r added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit e2dcdb3 Feb 10, 2026
17 checks passed
@whitep4nth3r whitep4nth3r deleted the update-contrib branch February 10, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants