Skip to content

fix: scroll to bottom should show footer #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 5 commits into from
Feb 11, 2026
Merged

fix: scroll to bottom should show footer #1352

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa16278
fix: re-position the buttongroup if the footer is visible (#1340)
ackzell Feb 10, 2026
198f34f
Merge branch 'main' of github.com:ackzell/npmx.dev into #1340-button-…
ackzell Feb 10, 2026
d6de956
Only using the intersection observer when on narrower screens.
ackzell Feb 10, 2026
b6bc012
refactor: Implementing useIntersectionObserver composable
ackzell Feb 10, 2026
72766b1
Merge branch 'npmx-dev:main' into #1340-button-group-overlaps-footer
ackzell Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 53 additions & 1 deletion app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const router = useRouter()

const header = useTemplateRef('header')
const isHeaderPinned = shallowRef(false)
const navExtraOffset = shallowRef(0)

function checkHeaderPosition() {
const el = header.value
Expand All @@ -40,13 +41,63 @@ function checkHeaderPosition() {
isHeaderPinned.value = Math.abs(rect.top - top) < 1
}

let footerEl: HTMLElement | null = null
let footerObserver: IntersectionObserver | null = null
let footerMediaQuery: MediaQueryList | null = null
const footerMediaHandler = (event: MediaQueryListEvent) => {
if (event.matches) {
setupFooterObserver()
} else {
teardownFooterObserver()
}
}

function setupFooterObserver() {
if (!footerEl) return
const thresholdValues = Array.from({ length: 101 }, (_, index) => index / 100)
footerObserver = new IntersectionObserver(
entries => {
const entry = entries[0]
if (!entry) return
navExtraOffset.value = entry.isIntersecting ? entry.intersectionRect.height : 0
},
{ threshold: thresholdValues },
)
footerObserver.observe(footerEl)
}

Copy link
Copy Markdown
Member

@danielroe danielroe Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about https://vueuse.org/core/useIntersectionObserver ?

Copy link
Copy Markdown
Contributor Author

@ackzell ackzell Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duh 😅

I'll update it.

function teardownFooterObserver() {
footerObserver?.disconnect()
footerObserver = null
navExtraOffset.value = 0
}

useEventListener('scroll', checkHeaderPosition, { passive: true })
useEventListener('resize', checkHeaderPosition)

onMounted(() => {
checkHeaderPosition()
footerEl = document.querySelector('footer')
if (!footerEl) return
footerMediaQuery = window.matchMedia('(max-width: 639.9px)')
if (footerMediaQuery.matches) {
setupFooterObserver()
} else {
teardownFooterObserver()
}
footerMediaQuery.addEventListener('change', footerMediaHandler)
})

onBeforeUnmount(() => {
teardownFooterObserver()
footerMediaQuery?.removeEventListener('change', footerMediaHandler)
footerMediaQuery = null
})

const navExtraOffsetStyle = computed(() => ({
'--package-nav-extra': `${navExtraOffset.value}px`,
}))

const { packageName, requestedVersion, orgName } = usePackageRoute()
const selectedPM = useSelectedPackageManager()
const activePmId = computed(() => selectedPM.value ?? 'npm')
Expand Down Expand Up @@ -647,6 +698,7 @@ onKeyStroke(
as="nav"
:aria-label="$t('package.navigation')"
class="hidden sm:flex max-sm:flex max-sm:fixed max-sm:z-40 max-sm:inset-is-1/2 max-sm:-translate-x-1/2 max-sm:rtl:translate-x-1/2 max-sm:bg-[--bg]/90 max-sm:backdrop-blur-md max-sm:border max-sm:border-border max-sm:rounded-md max-sm:shadow-md"
:style="navExtraOffsetStyle"
:class="$style.packageNav"
>
<LinkBase
Expand Down Expand Up @@ -1460,7 +1512,7 @@ onKeyStroke(
/* Mobile floating nav: safe-area positioning + kbd hiding */
@media (max-width: 639.9px) {
.packageNav {
bottom: calc(1.25rem + env(safe-area-inset-bottom, 0px));
bottom: calc(1.25rem + var(--package-nav-extra, 0px) + env(safe-area-inset-bottom, 0px));
}

.packageNav > :global(a kbd) {
Expand Down
Loading