fix: filter search cannot be typed#1376
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe changes refactor the filter text input binding in the Filter Panel component. A new computed property 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| const filterText = computed({ | ||
| get: () => props.filters.text, | ||
| set: value => emit('update:text', value), | ||
| }) |
There was a problem hiding this comment.
I think we should use a defineModel('text') instead
There was a problem hiding this comment.
This property comes from props.filters.text, so is defineModel('text') unnecessary?
If so, ListToolbar.vue would also need to be updated accordingly.
Referenced from
npmx.dev/app/components/Package/ListControls.vue
Lines 22 to 25 in 9aae078
There was a problem hiding this comment.
ahh, I see.
yes, this is awkward prop drilling we need to fix at some point but not in this PR
The search input in Filters cannot accept any input.
https://npmx.dev/org/vue