Skip to content

fix: semver sorting #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 4 commits into from
Jan 26, 2026
+10 −70
Merged

fix: semver sorting #143

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3b4821
fix: semver sorting
MatteoGabriele Jan 26, 2026
18eabf4
Merge branch 'main' into fix/semver-sorting
MatteoGabriele Jan 26, 2026
5047fe4
refactor: use semver compare directly
MatteoGabriele Jan 26, 2026
f5b8b0c
Merge remote-tracking branch 'upstream/main' into fix/semver-sorting
MatteoGabriele Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions app/utils/versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { valid } from 'semver'
import { compare, valid } from 'semver'

/**
* Utilities for handling npm package versions and dist-tags
Expand Down Expand Up @@ -47,19 +47,7 @@ export function parseVersion(version: string): ParsedVersion {
* @returns Comparison result for sorting
*/
export function compareVersions(a: string, b: string): number {
Copy link
Copy Markdown
Member

@danielroe danielroe Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just use compare wherever compareVersions is used instead of wrapping it?

Copy link
Copy Markdown
Member Author

@MatteoGabriele MatteoGabriele Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! I thought about keeping the wrapper for future changes, but it's indeed cleaner to use the package's method where needed, which also eliminates the need for tests.

const va = parseVersion(a)
const vb = parseVersion(b)

if (va.major !== vb.major) return va.major - vb.major
if (va.minor !== vb.minor) return va.minor - vb.minor
if (va.patch !== vb.patch) return va.patch - vb.patch

// Stable versions (no prerelease) are greater than prereleases
if (va.prerelease && vb.prerelease) return va.prerelease.localeCompare(vb.prerelease)
if (va.prerelease) return -1
if (vb.prerelease) return 1

return 0
return compare(a, b)
}

/**
Expand Down