Skip to content

test: add unit test for json module export detection#1452

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
eryue0220:feat/add-ut
Feb 13, 2026
Merged

test: add unit test for json module export detection#1452
danielroe merged 2 commits intonpmx-dev:mainfrom
eryue0220:feat/add-ut

Conversation

@eryue0220
Copy link
Copy Markdown
Contributor

This pr is add unit test for json module

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 13, 2026 1:29am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 13, 2026 1:29am
npmx-lunaria Ignored Ignored Feb 13, 2026 1:29am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 13, 2026

📝 Walkthrough

Walkthrough

This pull request adds two new test cases to the detectModuleFormat test suite within the package-analysis utility. The tests verify that the module format detection logic correctly identifies 'dual' format when both main and exports fields reference JSON files, and identifies 'esm' format when only the exports field references a JSON file. The changes consist of 21 new lines of test code with no deletions.

Possibly related PRs

Suggested reviewers

  • ghostdevv
  • danielroe
  • wojtekmaj
🚥 Pre-merge checks | ✅ 1 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (13 files):

⚔️ app/components/AppHeader.vue (content)
⚔️ app/components/CallToAction.vue (content)
⚔️ app/components/Header/AccountMenu.client.vue (content)
⚔️ app/components/Header/AuthModal.client.vue (content)
⚔️ app/components/Header/ConnectorModal.vue (content)
⚔️ app/pages/about.vue (content)
⚔️ i18n/locales/en.json (content)
⚔️ i18n/schema.json (content)
⚔️ lunaria/files/en-GB.json (content)
⚔️ lunaria/files/en-US.json (content)
⚔️ nuxt.config.ts (content)
⚔️ server/api/contributors.get.ts (content)
⚔️ test/unit/shared/utils/package-analysis.spec.ts (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately reflects the changeset, which adds unit tests for JSON module detection in the package-analysis test file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch feat/add-ut
  • Post resolved changes as copyable diffs in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe changed the title chore: add unit test for JSON module test: add unit test for JSON module Feb 13, 2026
@danielroe danielroe changed the title test: add unit test for JSON module test: add unit test for json module exports Feb 13, 2026
@danielroe danielroe changed the title test: add unit test for json module exports test: add unit test for json module export detection Feb 13, 2026
@danielroe danielroe added this pull request to the merge queue Feb 13, 2026
Merged via the queue into npmx-dev:main with commit c6952ce Feb 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants