Skip to content

chore: add type constraints for icon class names #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 4 commits into from
Feb 22, 2026
Merged

chore: add type constraints for icon class names #1538

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49a9e70
added proper typing for icon class names
Yusra89hash Feb 14, 2026
264e327
Merge remote-tracking branch 'origin/main' into Yusra89hash/main
danielroe Feb 22, 2026
ba5ab13
refactor: apply to other components with `classicon` prop
danielroe Feb 22, 2026
1af0163
chore: remove comment
danielroe Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/components/Button/Base.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<script setup lang="ts">
type StartIcon =
| `i-carbon:${string}`
| `i-lucide:${string}`
| `i-simple-icons:${string}`
| `i-svg-spinners:${string}`
| `i-custom:${string}`

const props = withDefaults(
defineProps<{
disabled?: boolean
Expand All @@ -8,7 +15,7 @@ const props = withDefaults(
ariaKeyshortcuts?: string
block?: boolean

classicon?: string
classicon?: StartIcon
}>(),
{
type: 'button',
Expand Down
3 changes: 2 additions & 1 deletion app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,9 @@ const { copied: copiedPkgName, copy: copyPkgName } = useClipboard({
})

//copy version name
//orginally only copied name and not version number
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Comment thread
danielroe marked this conversation as resolved.
Outdated
const { copied: copiedVersion, copy: copyVersion } = useClipboard({
source: resolvedVersion.value ?? '',
source: () => resolvedVersion.value ?? '',
copiedDuring: 2000,
})

Expand Down
Loading