Skip to content

fix(PackageVersions): make other versions list expand correctly #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Jan 27, 2026
Merged

fix(PackageVersions): make other versions list expand correctly #156

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d809eb9
fix(PackageVersions): make other versions list expand correctly
9romise Jan 27, 2026
414af59
fix: use new Set to handle expand status
9romise Jan 27, 2026
70ab9ad
Merge branch 'main' into fix/ref
9romise Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions app/components/PackageVersions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,8 @@ const tagVersions = ref<Map<string, VersionDisplay[]>>(new Map())
const loadingTags = ref<Set<string>>(new Set())

const otherVersionsExpanded = shallowRef(false)
const otherMajorGroups = shallowRef<
Array<{ major: number; versions: VersionDisplay[]; expanded: boolean }>
>([])
const expandedMajorGroups = ref<Set<number>>(new Set())
const otherMajorGroups = shallowRef<Array<{ major: number; versions: VersionDisplay[] }>>([])
const otherVersionsLoading = shallowRef(false)

// Cached full version list (local to component instance)
Expand Down Expand Up @@ -222,8 +221,8 @@ function processLoadedVersions(allVersions: PackageVersionInfo[]) {
otherMajorGroups.value = sortedMajors.map(major => ({
major,
versions: byMajor.get(major)!,
expanded: false,
}))
expandedMajorGroups.value.clear()
}

// Expand a tag row
Expand Down Expand Up @@ -277,10 +276,11 @@ async function expandOtherVersions() {
}

// Toggle a major group
function toggleMajorGroup(index: number) {
const group = otherMajorGroups.value[index]
if (group) {
group.expanded = !group.expanded
function toggleMajorGroup(major: number) {
if (expandedMajorGroups.value.has(major)) {
expandedMajorGroups.value.delete(major)
} else {
expandedMajorGroups.value.add(major)
}
}

Expand Down Expand Up @@ -497,20 +497,24 @@ function getTagVersions(tag: string): VersionDisplay[] {

<!-- Major version groups (untagged versions) -->
<template v-if="otherMajorGroups.length > 0">
<div v-for="(group, groupIndex) in otherMajorGroups" :key="group.major">
<div v-for="group in otherMajorGroups" :key="group.major">
<!-- Major group header -->
<button
v-if="group.versions.length > 1"
type="button"
class="w-full text-left py-1"
:aria-expanded="group.expanded"
:aria-expanded="expandedMajorGroups.has(group.major)"
:title="group.versions[0]?.version"
@click="toggleMajorGroup(groupIndex)"
@click="toggleMajorGroup(group.major)"
>
<div class="flex items-center gap-2">
<span
class="w-3 h-3 transition-transform duration-200 text-fg-subtle"
:class="group.expanded ? 'i-carbon-chevron-down' : 'i-carbon-chevron-right'"
:class="
expandedMajorGroups.has(group.major)
? 'i-carbon-chevron-down'
: 'i-carbon-chevron-right'
"
/>
<span
class="font-mono text-xs truncate"
Expand Down Expand Up @@ -567,7 +571,10 @@ function getTagVersions(tag: string): VersionDisplay[] {
</div>

<!-- Major group versions -->
<div v-if="group.expanded && group.versions.length > 1" class="ml-5 space-y-0.5">
<div
v-if="expandedMajorGroups.has(group.major) && group.versions.length > 1"
class="ml-5 space-y-0.5"
>
<div v-for="v in group.versions.slice(1)" :key="v.version" class="py-1">
<div class="flex items-center justify-between gap-2">
<NuxtLink
Expand Down