Skip to content

fix(ui): reduce size of link icon #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Feb 22, 2026
Merged

fix(ui): reduce size of link icon #1566

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d463da2
fix(ui): reduce size of link icon
radosvet93 Feb 22, 2026
e2e062d
fix(ui): moved to ::after
radosvet93 Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/Readme.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ function handleClick(event: MouseEvent) {

.readme :deep(a[href^='#']:hover::after) {
@apply opacity-100;
font-size: 0.75em;
Copy link
Copy Markdown
Member

@danielroe danielroe Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be set not just on hover, but in general on the ::after pseudo element

also a question: do we need to add some padding to increase tap target?

Copy link
Copy Markdown
Contributor Author

@radosvet93 radosvet93 Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes, it should be on the ::after!

Hmm, the whole heading is the tap target, so I don't think it needs padding in that case, unless we want to add functionality to copy to clipboard only when the icon is clicked, then probably it's good to have a bigger tap target specifically for the icon

Copy link
Copy Markdown
Member

@danielroe danielroe Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

}

.readme :deep(code) {
Expand Down
Loading