Skip to content

fix: don't intercept clicks on icon in team cards#1569

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
rzzf:fix/1562
Feb 22, 2026
Merged

fix: don't intercept clicks on icon in team cards#1569
danielroe merged 1 commit intonpmx-dev:mainfrom
rzzf:fix/1562

Conversation

@rzzf
Copy link
Copy Markdown
Contributor

@rzzf rzzf commented Feb 22, 2026

🔗 Linked issue

resolves #1562

🧭 Context

📚 Description

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 22, 2026 10:49am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 22, 2026 10:49am
npmx-lunaria Ignored Ignored Feb 22, 2026 10:49am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 22, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The change addresses the governance member list item by adding the pointer-events-none class to the external link icon element in app/pages/about.vue. This modification prevents the icon from intercepting pointer events, allowing click interactions to pass through to the underlying clickable area. The adjustment consists of a single-line modification with no alterations to control flow or error handling logic.

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description lacks detailed explanation of the changes made, containing only the linked issue reference without context or implementation details. Provide a brief description explaining the problem, solution, and rationale for adding the pointer-events-none class to the icon element.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The code change directly addresses issue #1562 by adding the pointer-events-none CSS class to the external link icon element as requested.
Out of Scope Changes check ✅ Passed The change is precisely scoped to the requirements in issue #1562, with only one CSS class addition to the governance member list icon.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe changed the title fix: link icon does not respond when clicked fix: don't intercept clicks on icon in team cards Feb 22, 2026
@danielroe danielroe added this pull request to the merge queue Feb 22, 2026
Merged via the queue into npmx-dev:main with commit 93ee4b1 Feb 22, 2026
18 checks passed
@rzzf rzzf deleted the fix/1562 branch February 22, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New tab icon in governance card

2 participants