Skip to content

fix: adjust colors in filters ui for better contrast#1659

Merged
alexdln merged 9 commits intonpmx-dev:mainfrom
jellydeck:tasty-tabs
Feb 26, 2026
Merged

fix: adjust colors in filters ui for better contrast#1659
alexdln merged 9 commits intonpmx-dev:mainfrom
jellydeck:tasty-tabs

Conversation

@jellydeck
Copy link
Copy Markdown
Contributor

@jellydeck jellydeck commented Feb 26, 2026

adjusting colors for better contrast

Before

20260226-0931-08.7631564.mp4

After

8mb.video-VZP-h3u2rSwK.2.mp4

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 26, 2026 10:55am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 26, 2026 10:55am
npmx-lunaria Ignored Ignored Feb 26, 2026 10:55am

Request Review

@jellydeck jellydeck changed the title feat: filters ui/ux feat: filters ui update Feb 26, 2026
@jellydeck jellydeck marked this pull request as ready for review February 26, 2026 09:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 26, 2026

📝 Walkthrough

Walkthrough

The ViewModeToggle.vue component’s styling was adjusted: the outer container class changed from bg-bg-subtle to bg-bg-muted. Toggle buttons now include visible border classes. Each button’s active state uses bg-bg-subtle, text-fg, and border-fg-subtle; inactive state uses text-fg-muted with border-transparent. Button class bindings were refactored from a single-line conditional to a multiline form with explicit cards/table blocks. Focus-ring utilities, aria-pressed attributes, and click handlers were preserved.

Suggested reviewers

  • alexdln
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, describing a colour contrast adjustment that aligns with the CSS background class modifications shown in the file summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
app/components/ViewModeToggle.vue (1)

15-16: Remove per-button focus-visible ring utilities to match project-wide focus styling.

These two button class strings still include inline focus-visible:ring-* utilities. This component should rely on the global button:focus-visible rule for consistency.

Suggested diff
-      class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200 focus-visible:ring-2 focus-visible:ring-fg focus-visible:ring-offset-1"
+      class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200"
...
-      class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200 focus-visible:ring-2 focus-visible:ring-fg focus-visible:ring-offset-1"
+      class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200"

Based on learnings: In the npmx.dev project, focus-visible styling for button and select elements is applied globally via app/assets/main.css; individual inline focus-visible utility classes should be avoided.

Also applies to: 30-31


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b2b2b0 and 1453c8b.

📒 Files selected for processing (1)
  • app/components/ViewModeToggle.vue

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe changed the title feat: filters ui update fix: adjust colors in filters ui for better contrast Feb 26, 2026
@alexdln alexdln enabled auto-merge February 26, 2026 10:54
@alexdln alexdln added this pull request to the merge queue Feb 26, 2026
Merged via the queue into npmx-dev:main with commit 098c2aa Feb 26, 2026
17 checks passed
@jellydeck jellydeck deleted the tasty-tabs branch February 26, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants