fix: adjust colors in filters ui for better contrast#1659
fix: adjust colors in filters ui for better contrast#1659alexdln merged 9 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe ViewModeToggle.vue component’s styling was adjusted: the outer container class changed from Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/components/ViewModeToggle.vue (1)
15-16: Remove per-button focus-visible ring utilities to match project-wide focus styling.These two button class strings still include inline
focus-visible:ring-*utilities. This component should rely on the globalbutton:focus-visiblerule for consistency.Suggested diff
- class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200 focus-visible:ring-2 focus-visible:ring-fg focus-visible:ring-offset-1" + class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200" ... - class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200 focus-visible:ring-2 focus-visible:ring-fg focus-visible:ring-offset-1" + class="inline-flex items-center px-2.5 py-1.5 text-sm font-medium rounded-sm border transition-colors duration-200"Based on learnings: In the npmx.dev project, focus-visible styling for button and select elements is applied globally via
app/assets/main.css; individual inline focus-visible utility classes should be avoided.Also applies to: 30-31
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
adjusting colors for better contrast
Before
20260226-0931-08.7631564.mp4
After
8mb.video-VZP-h3u2rSwK.2.mp4