-
-
Notifications
You must be signed in to change notification settings - Fork 424
fix: unexpected unknown type for api docs format type
#1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
test/fixtures/esm-sh/doc-nodes/linkdave@0.0.2-client-message.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| { | ||
| "name": "ClientMessage", | ||
| "kind": "typeAlias", | ||
| "typeAliasDef": { | ||
| "tsType": { | ||
| "repr": "", | ||
| "kind": "union", | ||
| "union": [ | ||
| { | ||
| "repr": "", | ||
| "kind": "typeLiteral", | ||
| "typeLiteral": { | ||
| "properties": [ | ||
| { | ||
| "name": "op", | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "voiceUpdate", | ||
| "kind": "literal", | ||
| "literal": { "kind": "string", "string": "voiceUpdate" } | ||
| } | ||
| }, | ||
| { | ||
| "name": "guildId", | ||
| "optional": false, | ||
| "tsType": { "repr": "string", "kind": "keyword", "keyword": "string" } | ||
| } | ||
| ], | ||
| "methods": [], | ||
| "callSignatures": [], | ||
| "indexSignatures": [] | ||
| } | ||
| }, | ||
| { | ||
| "repr": "", | ||
| "kind": "typeLiteral", | ||
| "typeLiteral": { | ||
| "properties": [ | ||
| { | ||
| "name": "op", | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "play", | ||
| "kind": "literal", | ||
| "literal": { "kind": "string", "string": "play" } | ||
| } | ||
| }, | ||
| { | ||
| "name": "guildId", | ||
| "optional": false, | ||
| "tsType": { "repr": "string", "kind": "keyword", "keyword": "string" } | ||
| } | ||
| ], | ||
| "methods": [], | ||
| "callSignatures": [], | ||
| "indexSignatures": [] | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "typeParams": [] | ||
| } | ||
| } |
158 changes: 158 additions & 0 deletions
158
test/fixtures/esm-sh/doc-nodes/linkdave@0.0.2-client.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| { | ||
| "name": "LinkDaveClient", | ||
| "kind": "interface", | ||
| "interfaceDef": { | ||
| "extends": [], | ||
| "constructors": [], | ||
| "methods": [], | ||
| "properties": [ | ||
| { | ||
| "name": "on", | ||
| "computed": false, | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "", | ||
| "kind": "fnOrConstructor", | ||
| "fnOrConstructor": { | ||
| "constructor": false, | ||
| "tsType": { "repr": "this", "kind": "this", "this": true }, | ||
| "params": [ | ||
| { | ||
| "kind": "identifier", | ||
| "name": "event", | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "K", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "K" } | ||
| } | ||
| }, | ||
| { | ||
| "kind": "identifier", | ||
| "name": "listener", | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "", | ||
| "kind": "fnOrConstructor", | ||
| "fnOrConstructor": { | ||
| "constructor": false, | ||
| "tsType": { "repr": "void", "kind": "keyword", "keyword": "void" }, | ||
| "params": [ | ||
| { | ||
| "kind": "identifier", | ||
| "name": "data", | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "", | ||
| "kind": "indexedAccess", | ||
| "indexedAccess": { | ||
| "readonly": false, | ||
| "objType": { | ||
| "repr": "ManagerEvents", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "ManagerEvents" } | ||
| }, | ||
| "indexType": { | ||
| "repr": "K", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "K" } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "typeParams": [] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "typeParams": [ | ||
| { | ||
| "name": "K", | ||
| "constraint": { | ||
| "repr": "", | ||
| "kind": "typeOperator", | ||
| "typeOperator": { | ||
| "operator": "keyof", | ||
| "tsType": { | ||
| "repr": "ManagerEvents", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "ManagerEvents" } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "emit", | ||
| "computed": false, | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "", | ||
| "kind": "fnOrConstructor", | ||
| "fnOrConstructor": { | ||
| "constructor": false, | ||
| "tsType": { "repr": "boolean", "kind": "keyword", "keyword": "boolean" }, | ||
| "params": [ | ||
| { | ||
| "kind": "identifier", | ||
| "name": "event", | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "K", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "K" } | ||
| } | ||
| }, | ||
| { | ||
| "kind": "identifier", | ||
| "name": "data", | ||
| "optional": false, | ||
| "tsType": { | ||
| "repr": "", | ||
| "kind": "indexedAccess", | ||
| "indexedAccess": { | ||
| "readonly": false, | ||
| "objType": { | ||
| "repr": "ManagerEvents", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "ManagerEvents" } | ||
| }, | ||
| "indexType": { | ||
| "repr": "K", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "K" } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "typeParams": [ | ||
| { | ||
| "name": "K", | ||
| "constraint": { | ||
| "repr": "", | ||
| "kind": "typeOperator", | ||
| "typeOperator": { | ||
| "operator": "keyof", | ||
| "tsType": { | ||
| "repr": "ManagerEvents", | ||
| "kind": "typeRef", | ||
| "typeRef": { "typeName": "ManagerEvents" } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "callSignatures": [], | ||
| "indexSignatures": [], | ||
| "typeParams": [] | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 2493
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 581
🏁 Script executed:
rg -n "interface.*TsType|type.*TsType" server/utils/docs/ -A 30Repository: npmx-dev/npmx.dev
Length of output: 5460
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 229
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 340
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 3442
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 262
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 262
🏁 Script executed:
Repository: npmx-dev/npmx.dev
Length of output: 482
fnOrConstructorformatting drops generic constraints and constructor semantics.Line 117 ignores the
constraintfield of type parameters (e.g.K extends keyof ...), and line 121 does not check theconstructorboolean flag, so constructor signatures are rendered as plain function arrows instead of constructor syntax.Proposed fix
function formatFnOrConstructorType(fn: NonNullable<TsType['fnOrConstructor']>): string { - const typeParams = fn.typeParams?.map(t => t.name).join(', ') + const typeParams = fn.typeParams + ?.map(t => (t.constraint ? `${t.name} extends ${formatType(t.constraint)}` : t.name)) + .join(', ') const typeParamsStr = typeParams ? `<${typeParams}>` : '' const params = fn.params.map(p => formatParam(p)).join(', ') const ret = formatType(fn.tsType) || 'void' - return `${typeParamsStr}(${params}) => ${ret}` + const ctorPrefix = fn.constructor ? 'new ' : '' + return `${ctorPrefix}${typeParamsStr}(${params}) => ${ret}` }📝 Committable suggestion