Skip to content

feat: light theme#172

Merged
danielroe merged 16 commits intonpmx-dev:mainfrom
jellydeck:light-theme
Jan 27, 2026
Merged

feat: light theme#172
danielroe merged 16 commits intonpmx-dev:mainfrom
jellydeck:light-theme

Conversation

@jellydeck
Copy link
Copy Markdown
Contributor

@jellydeck jellydeck commented Jan 27, 2026

closes #108

theme is derived from css variables at :root, then using data-theme prop on root (html) tag we toggle between themes.

tasks:

  • move all hardcoded colors to css variables
  • use oklch colors
  • theme preference persistence (local storage?)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 27, 2026

@jellydeck is attempting to deploy a commit to the danielroe Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
npmx-dev-docs Ready Ready Preview, Comment Jan 27, 2026 8:54pm
npmx.dev Ready Ready Preview, Comment Jan 27, 2026 8:54pm

Request Review

Copy link
Copy Markdown
Contributor

@Kai-ros Kai-ros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment thread app/components/PackageDownloadStats.vue Outdated
@danielroe
Copy link
Copy Markdown
Member

probably worth merging in upstream changes, including a settings ui for a accent colour

@jellydeck jellydeck marked this pull request as ready for review January 27, 2026 18:29
Comment thread app/app.vue Outdated
@danielroe danielroe merged commit 3c84708 into npmx-dev:main Jan 27, 2026
9 checks passed
vinnymac pushed a commit to vinnymac/npmx.dev that referenced this pull request Jan 28, 2026
@jellydeck jellydeck deleted the light-theme branch January 28, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Light mode

3 participants