Skip to content

fix: fix column picker reset button margin#1859

Merged
serhalp merged 1 commit intomainfrom
shuuji3/fix/column-picker-margin
Mar 3, 2026
Merged

fix: fix column picker reset button margin#1859
serhalp merged 1 commit intomainfrom
shuuji3/fix/column-picker-margin

Conversation

@shuuji3
Copy link
Copy Markdown
Member

@shuuji3 shuuji3 commented Mar 3, 2026

🔗 Linked issue

N/A (skipped because of small fix)

🧭 Context

The reset button in the column picker (on table view) has no margin at the left side.

📚 Description

  • Adjusted the button margin by setting equal margins around the button.

Before

Screenshot of reset button, left side is at the left border of popup component

After

Screenshot of reset button, having equal margins aroung the button

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 3, 2026 2:31am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Mar 3, 2026 2:31am
npmx-lunaria Ignored Ignored Mar 3, 2026 2:31am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c29857 and 5240e91.

📒 Files selected for processing (1)
  • app/components/ColumnPicker.vue

📝 Walkthrough

Walkthrough

The pull request modifies the styling of the reset button container in the ColumnPicker component. The container's CSS classes were updated from "border-t border-border py-1" to "border-t border-border p-2 pb-1". This change increases the overall padding of the container whilst maintaining a specific bottom padding value. No modifications were made to the event handling logic, component state, or control flow.

Suggested reviewers

  • danielroe
  • alexdln
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly explains the issue (reset button lacking left margin) and describes the fix with before/after screenshots demonstrating the margin adjustment.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shuuji3/fix/column-picker-margin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalp serhalp enabled auto-merge March 3, 2026 02:45
@serhalp serhalp disabled auto-merge March 3, 2026 02:53
@serhalp serhalp added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 670d47d Mar 3, 2026
24 checks passed
@serhalp serhalp deleted the shuuji3/fix/column-picker-margin branch March 3, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants