fix: focus settings toggle when opening with keyboard shortcut#186
Merged
danielroe merged 1 commit intonpmx-dev:mainfrom Jan 27, 2026
Conversation
|
@jhroemer is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danielroe
approved these changes
Jan 27, 2026
danielroe
changed the title
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the focus tab order is not correct after opening the settings menu with the
,shortcut (it stays where it is, instead of moving to the menu). This PR addresses the issue by focusing the settings button and clicking it programmatically, instead of simply toggling theisOpenvalue.Before:
https://github.com/user-attachments/assets/4f8a52f9-36f5-4cdb-b5b2-d146253cbc75
After:
https://github.com/user-attachments/assets/27bf26e8-4bf9-4e48-be64-38c1dae8a922