Skip to content

feat: add clear button in search input #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 5 commits into from
Mar 5, 2026
Merged

feat: add clear button in search input #1895

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8c3873
fix: add clear button in search field (mobile view) - #1881
SahulKola Mar 3, 2026
8bcbeed
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 3, 2026
301e56c
feat: update accessibility and make visible only on focus/hover
ghostdevv Mar 5, 2026
fd2a652
Update app/components/Header/SearchBox.vue
ghostdevv Mar 5, 2026
3e17ada
Merge branch 'main' into fix/add-clear-icon-in-search-field-for-mobil…
ghostdevv Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion app/components/Header/SearchBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,17 @@ const showSearchBar = computed(() => {
})

const { model: searchQuery, startSearch } = useGlobalSearch('header')
const hasSearchQuery = computed(() => searchQuery.value.trim().length > 0)

function handleSubmit() {
startSearch()
}

function clearSearch() {
searchQuery.value = ''
inputRef.value?.focus()
}

// Expose focus method for parent components
const inputRef = useTemplateRef('inputRef')
function focus() {
Expand Down Expand Up @@ -52,11 +58,20 @@ defineExpose({ focus })
name="q"
:placeholder="$t('search.placeholder')"
no-correct
class="w-full min-w-25 ps-7"
class="w-full min-w-25 ps-7 pe-8"
@focus="isSearchFocused = true"
@blur="isSearchFocused = false"
size="small"
/>
<button
v-if="hasSearchQuery"
type="button"
:aria-label="$t('common.close')"
Comment thread
ghostdevv marked this conversation as resolved.
Outdated
class="absolute inset-ie-2 inline-flex h-6 w-6 items-center justify-center rounded text-fg-muted hover:text-fg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent"
@click="clearSearch"
>
<span class="i-lucide:circle-x h-4 w-4" aria-hidden="true" />
</button>
Comment thread
coderabbitai[bot] marked this conversation as resolved.
<button type="submit" class="sr-only">{{ $t('search.button') }}</button>
</div>
</div>
Expand Down
Loading