refactor: use interest invokers for contributor hovercard#1985
refactor: use interest invokers for contributor hovercard#1985knowler wants to merge 7 commits intouserquin/feat-add-contributors-popup-cardfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
e6de0b3 to
d9c61ce
Compare
TODO: will add the v-if/v-else back with the link fallback
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Thank you for your contribution! 🙏 This PR has been inactive for 30 days and is now marked as stale. If there's no activity in the next 14 days, it will be closed to keep our repository tidy. To keep this PR open, feel free to:
We appreciate your interest in npmx and hope you'll continue contributing! 💙 |
|
I’m going to close this. I think the approach would be great, however, interest invokers themselves are at risk in standards land. We can still glean from them with regard to some of the good research that has be done for them (with regard to accessibility, etc.). |
Refactoring #1596 to use interest invokers, the Popover API, and anchor positioning instead. This is partly an experiment, so don’t let this block you from iterating on your PR @userquin.
Using these web platform APIs means we don’t need to add a whole lot of complexity to pull this off. The only JS we need is to update the
activeContributorusing thebeforetoggleevent for the popover.This only works in Chromium, so we have a couple of options:
Anchor positioning is only Baseline Newly Available as of December, but it does already have 81% availability in browsers globally.
I personally don’t think it’s worth it to try and create behavioural parity across all of our browser targets here. The content is likely available if the user just clicks through the GitHub links. The only thing that is missing is the governance roles, which might might be able to find a solution (grouping under separate headings would be the most easily accessible, especially from an information architecture perspective).
TODO