Skip to content

fix(ui): preview mode show the pr number #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 5 commits into from
Mar 21, 2026
Merged

fix(ui): preview mode show the pr number #2018

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffa05b4
fix(ui): preview mode show the pr number
btea Mar 10, 2026
4715ebc
feat: apply review
btea Mar 10, 2026
c39ce27
fix: remove extra spacing
ghostdevv Mar 20, 2026
e610314
refactor: reduce duplication
ghostdevv Mar 20, 2026
3a21abd
Merge branch 'main' into fix/mobile-show-pr-number
ghostdevv Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,16 @@ onKeyStroke(
>
<AppMark class="w-6 h-auto" />
</NuxtLink>
<NuxtLink
v-if="!isSearchExpanded && !isOnHomePage && prNumber"
:to="`https://github.com/npmx-dev/npmx.dev/pull/${prNumber}`"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
:aria-label="`Open GitHub pull request ${prNumber}`"
class="sm:hidden"
>
<span class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium ms-2">
PR #{{ prNumber }}
Comment thread
btea marked this conversation as resolved.
Outdated
Copy link
Copy Markdown
Member

@serhalp serhalp Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're internationalizing this feature, maybe "PR" should be translated as well?

Copy link
Copy Markdown
Contributor Author

@btea btea Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, those who see this information on the page are usually redirected through a Premiere Pro (PR) preview link. I assume that those familiar with these operations are developers, and based on this assumption, PR seems to be a very clear abbreviation, so I don't think it needs to be translated.

Of course, if you feel this reason is insufficient, we can continue to discuss it.

Copy link
Copy Markdown
Contributor

@ghostdevv ghostdevv Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Premiere Pro

What xD

if we're internationalizing this feature, maybe "PR" should be translated as well?

I think it's ok not being translated, I couldn't find it anywhere else translated, or with the current desktop version of this feature - but we can always translate it in a follow up!

</span>
</NuxtLink>

<!-- Desktop: Logo (navigates home) -->
<div v-if="showLogo" class="hidden sm:flex flex-shrink-0 items-center">
Expand Down
Loading