Skip to content

fix: normalize search queries to lowercase #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sacrosanctic wants to merge 2 commits into from
Closed

fix: normalize search queries to lowercase #210

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3db77e2
fix: normalize search queries to lowercase for consistent results
sacrosanctic Jan 28, 2026
e6d0e1d
move the logic upstream
sacrosanctic Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/composables/useNpmRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export function useNpmSearch(
}

const params = new URLSearchParams()
params.set('text', q)
params.set('text', q.toLowerCase())
Copy link
Copy Markdown
Member

@serhalp serhalp Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I'll defer to @danielroe here but I think ideally we would normalize this a bit further upstream so that the caching (line 241–242) can collapse to a normalize key.

Copy link
Copy Markdown
Member

@danielroe danielroe Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that makes sense.

also - if the API returns different results based on case, is this really something we should obscure?

const opts = toValue(options)
if (opts.size) params.set('size', String(opts.size))
if (opts.from) params.set('from', String(opts.from))
Expand Down
Loading