-
-
Notifications
You must be signed in to change notification settings - Fork 424
fix: added scroll preservation opt in to the compare page #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphieros
merged 5 commits into
npmx-dev:main
from
mihaizaurus:scroll-preservation-on-input-change
Mar 16, 2026
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
78d8cce
added scroll preservation opt in to the compare page to avoid input u…
mihaizaurus 507be8c
updated with changes from coderabbit's comments
mihaizaurus 8bc8543
fix: remove unused var underscore
graphieros 9907685
[autofix.ci] apply automated fixes
autofix-ci[bot] 306d1e7
Merge branch 'main' into scroll-preservation-on-input-change
graphieros File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { describe, expect, it } from 'vitest' | ||
| import routerOptions from '../../../app/router.options' | ||
|
|
||
| type ScrollBehavior = NonNullable<typeof routerOptions.scrollBehavior> | ||
| type RouteArg = Parameters<ScrollBehavior>[0] | ||
|
|
||
| function createRoute(overrides: Partial<RouteArg> = {}) { | ||
| return { | ||
| path: '/', | ||
| hash: '', | ||
| query: {}, | ||
| meta: {}, | ||
| ...overrides, | ||
| } as RouteArg | ||
| } | ||
|
|
||
| describe('router scrollBehavior', () => { | ||
| it('restores saved position when available', () => { | ||
| const savedPosition = { left: 12, top: 345 } | ||
|
|
||
| expect(routerOptions.scrollBehavior(createRoute(), createRoute(), savedPosition)).toEqual( | ||
| savedPosition, | ||
| ) | ||
| }) | ||
|
|
||
| it('preserves scroll on query-only updates for pages that opt in', () => { | ||
| const to = createRoute({ | ||
| path: '/compare', | ||
| query: { packages: 'vue,nuxt', facets: 'downloads,license' }, | ||
| meta: { preserveScrollOnQuery: true }, | ||
| }) | ||
| const from = createRoute({ | ||
| path: '/compare', | ||
| query: { packages: 'vue', facets: 'downloads' }, | ||
| meta: { preserveScrollOnQuery: true }, | ||
| }) | ||
|
|
||
| expect(routerOptions.scrollBehavior(to, from, null)).toBe(false) | ||
| }) | ||
|
|
||
| it('does not preserve scroll on query-only updates without opt-in', () => { | ||
| const to = createRoute({ | ||
| path: '/compare', | ||
| query: { packages: 'vue,nuxt', facets: 'downloads,license' }, | ||
| }) | ||
| const from = createRoute({ | ||
| path: '/compare', | ||
| query: { packages: 'vue', facets: 'downloads' }, | ||
| }) | ||
|
|
||
| expect(routerOptions.scrollBehavior(to, from, null)).toEqual({ left: 0, top: 0 }) | ||
| }) | ||
|
|
||
| it('scrolls to hash anchors', () => { | ||
| const to = createRoute({ | ||
| hash: '#section-function', | ||
| meta: { scrollMargin: 96 }, | ||
| }) | ||
|
|
||
| expect(routerOptions.scrollBehavior(to, createRoute(), null)).toEqual({ | ||
| el: '#section-function', | ||
| behavior: 'smooth', | ||
| top: 96, | ||
| }) | ||
| }) | ||
|
|
||
| it('scrolls to top for regular navigations', () => { | ||
| const to = createRoute({ path: '/compare', meta: { preserveScrollOnQuery: true } }) | ||
| const from = createRoute({ path: '/search' }) | ||
|
|
||
| expect(routerOptions.scrollBehavior(to, from, null)).toEqual({ left: 0, top: 0 }) | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.