Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
resolves #2049
🧭 Context
Some warnings shown in the skills modal and diff sidebar were previously hardcoded English strings produced on the server.
This change localizes those warnings by returning structured warning messages with translation keys, then translating them in the UI through a shared composable.
📚 Description
Changes:
WarningMessagetype for structured warningsuseI18nWarning()I went back and forth a bit on whether these warnings should remain entirely client-derived, since there are already places in the project where warning-like UI text is built on the frontend.
Following the discussion in #2049 with @ShroXd, it felt worthwhile to establish this pattern here: it not only improves i18n handling, but also gives us a clearer structure for information flow, while translation keys remain semantic and readable.
So this PR also serves as an experiment to explore what this direction would look like in practice.
One thing to note is that this also introduces a dynamic key mechanism that isn't currently accepted by the existing i18n validation.