Skip to content

fix: don't diff install size with first version #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 4 commits into from
Mar 21, 2026
+35 −5
Merged

fix: don't diff install size with first version #2175

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df7d8c2
fix: don't diff install size with first version
43081j Mar 20, 2026
e290852
Merge branch 'main' into jg/big-diffs-in-early-days
ghostdevv Mar 20, 2026
cc4dd68
test: fix 'em up
43081j Mar 21, 2026
6f34fd2
Merge branch 'main' into jg/big-diffs-in-early-days
ghostdevv Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/composables/useInstallSizeDiff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ function getComparisonVersion(pkg: SlimPackument, resolvedVersion: string): stri
.sort((a, b) => compare(a, b))

const currentIdx = stableVersions.indexOf(resolvedVersion)
if (currentIdx <= 0) return null
// Don't compare the second version against the first as the first
// has no baseline so a large size difference is expected
if (currentIdx <= 1) return null

return stableVersions[currentIdx - 1]!
}
Expand Down
Loading