refactor: move settings to a page#225
Merged
danielroe merged 6 commits intonpmx-dev:mainfrom Jan 28, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danielroe
reviewed
Jan 28, 2026
Member
danielroe
left a comment
danielroe
left a comment
There was a problem hiding this comment.
the toggles appear to have less contrast for me, so I think we probably need to resolve before merge
I'll have a quick look at a design....
Member
Author
|
@danielroe, it definitely has less contrast because there's no background. Do we have designs that I can look at, otherwise I can play with it a little I do feel that toggles should probably change their background color when toggled off. They will never work when placed on a plain background |
…/MatteoGabriele/npmx.dev into refactor/move-settings-to-a-page
Member
Author
|
@danielroe made some tweaks. Feel free to change anything you want to change |
danielroe
approved these changes
Jan 28, 2026
Member
danielroe
left a comment
danielroe
left a comment
There was a problem hiding this comment.
nice! I think we can iterate on this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the settings panel to an actual page
closes #222
Notes
I didn't pay attention to a redesign, but we need to check it out, especially regarding the low visibility of toggles.