Skip to content

feat(package): add fund button#233

Merged
43081j merged 1 commit intonpmx-dev:mainfrom
9romise:feat/fund
Jan 28, 2026
Merged

feat(package): add fund button#233
43081j merged 1 commit intonpmx-dev:mainfrom
9romise:feat/fund

Conversation

@9romise
Copy link
Copy Markdown
Member

@9romise 9romise commented Jan 28, 2026

Resolves #226
I'm not sure if there's enough space in this area. I'd like to get a better approach
image

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 28, 2026 1:21pm
npmx.dev Ready Ready Preview, Comment Jan 28, 2026 1:21pm

Request Review

@okineadev
Copy link
Copy Markdown
Contributor

Great!

I wanted to do this too but couldn't figure out where to get the package.json data

I think it would be better to make the same big button on the right side as on https://npmjs.com

Copy link
Copy Markdown
Contributor

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me 👍

this is probably the most sensible place to render it for now at least too. if that bar gets too busy eventually, we can split it up a bit

i do agree in future maybe we want a sidebar link instead, but this seems good for now

@43081j 43081j added this pull request to the merge queue Jan 28, 2026
Merged via the queue into npmx-dev:main with commit 3476c47 Jan 28, 2026
9 checks passed
@9romise 9romise deleted the feat/fund branch January 28, 2026 14:41
@okineadev
Copy link
Copy Markdown
Contributor

seems good to me 👍

this is probably the most sensible place to render it for now at least too. if that bar gets too busy eventually, we can split it up a bit

i do agree in future maybe we want a sidebar link instead, but this seems good for now

It's just such a small link that hardly anyone will notice

@okineadev
Copy link
Copy Markdown
Contributor

I noticed a new bug - when there are too many links, they wrap incorrectly to the right instead of the left:

image

danielroe pushed a commit to okineadev/npmx.dev that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sponsor button?

3 participants