Skip to content

refactor: add missing IconClass type to icon props #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 6 commits into from
Apr 11, 2026
Merged

refactor: add missing IconClass type to icon props #2462

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64c2017
feat: add IconClass typing to icon props
C1ANCYSz Apr 10, 2026
bee318a
Merge branch 'main' into main
C1ANCYSz Apr 10, 2026
93ee60d
Update app/components/Diff/SidebarPanel.vue
C1ANCYSz Apr 10, 2026
6b5ec24
Update app/components/CollapsibleSection.vue
C1ANCYSz Apr 10, 2026
2fc09b3
Merge branch 'main' into main
C1ANCYSz Apr 10, 2026
f18e9d1
Merge branch 'main' into main
C1ANCYSz Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/components/CollapsibleSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
<script setup lang="ts">
import { shallowRef, computed } from 'vue'
import { LinkBase } from '#components'
import type { IconClass } from '../types/icon'
Comment thread
C1ANCYSz marked this conversation as resolved.
Outdated

interface Props {
title: string
subtitle?: string
isLoading?: boolean
headingLevel?: `h${number}`
id: string
icon?: string
icon?: IconClass
}

const props = withDefaults(defineProps<Props>(), {
Expand Down
3 changes: 2 additions & 1 deletion app/components/Diff/SidebarPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script setup lang="ts">
import { packageRoute } from '~/utils/router'
import type { IconClass } from '../../types/icon'
Comment thread
C1ANCYSz marked this conversation as resolved.
Outdated

const props = defineProps<{
compare: CompareResponse
Expand All @@ -19,7 +20,7 @@ const fileFilter = defineModel<'all' | 'added' | 'removed' | 'modified'>('fileFi

const sectionOrder = ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies']
const { t } = useI18n()
const sectionMeta = computed<Record<string, { label: string; icon: string }>>(() => ({
const sectionMeta = computed<Record<string, { label: string; icon: IconClass }>>(() => ({
dependencies: { label: t('compare.dependencies'), icon: 'i-lucide:box' },
devDependencies: { label: t('compare.dev_dependencies'), icon: 'i-lucide:wrench' },
peerDependencies: { label: t('compare.peer_dependencies'), icon: 'i-lucide:users' },
Expand Down
Loading