Skip to content

fix: round chart numbers in applyDataCorrection for consistent rounding #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphieros merged 6 commits into from
Apr 18, 2026
+5 −8
Merged

fix: round chart numbers in applyDataCorrection for consistent rounding #2556

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47bd16e
fix: round downloads to avoid fractions showing up when hovering Week…
ulrichstark Apr 17, 2026
0d2cc49
Revert "fix: round downloads to avoid fractions showing up when hover…
ulrichstark Apr 17, 2026
7881b72
add rounding as last step to applyDataCorrection
ulrichstark Apr 17, 2026
3cc9d17
update comment
ulrichstark Apr 17, 2026
8f79b84
Revert "fix: show integers for values below 1k in trends chart toolti…
ulrichstark Apr 18, 2026
811945c
remove maximumFractionDigits in SplitSparkline and WeeklyDownloadStats
ulrichstark Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/utils/chart-data-correction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export interface ChartFilterSettings {
}

/**
* Applies moving average then smoothing in sequence.
* Applies moving average, smoothing and then rounding up in sequence.
*/
export function applyDataCorrection<T extends { value: number }>(
data: T[],
Expand All @@ -92,5 +92,6 @@ export function applyDataCorrection<T extends { value: number }>(
let result = data
result = movingAverage(result, settings.averageWindow)
result = smoothing(result, settings.smoothingTau)
result = result.map(d => ({ ...d, value: Math.ceil(d.value) }))
return result
}
Loading