Merged
Conversation
|
@devdumpling is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
devdumpling
commented
Jan 24, 2026
Contributor
Author
There was a problem hiding this comment.
oops ignore this change, will pull it out--meant to only keep it in this PR: #26
will pull it shortly
devdumpling
commented
Jan 24, 2026
Comment on lines
+7
to
+24
| const mockFetchOk = <T>(body: T) => { | ||
| const fetchMock = vi.fn().mockResolvedValue({ | ||
| ok: true, | ||
| json: async () => body, | ||
| }) | ||
| vi.stubGlobal('fetch', fetchMock) | ||
| return fetchMock | ||
| } | ||
|
|
||
| const mockFetchError = (status: number) => { | ||
| const fetchMock = vi.fn().mockResolvedValue({ | ||
| ok: false, | ||
| status, | ||
| }) | ||
| vi.stubGlobal('fetch', fetchMock) | ||
| return fetchMock | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Could move these out for re-use but haven't looked at all the testing patterns in place yet in full
devdumpling
commented
Jan 24, 2026
|
|
||
| describe('convertToFileTree', () => { | ||
| it('converts jsDelivr nodes to a sorted tree with directories first', () => { | ||
| const input: JsDelivrFileNode[] = [ |
Contributor
Author
There was a problem hiding this comment.
Not super familiar with jsDeliver. LMK if this is too rudimentary.
Member
|
this is great - thank you! ❤️ |
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Wanted to get a better understanding of the repo so started trying to add some tests. Looks like these server utils were a bit underserved and relatively pure / understandable. Let me know if you have any questions / thoughts.