Skip to content

feat: show more maintainers #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 7 commits into from
Jan 29, 2026
Merged

feat: show more maintainers #316

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d3d56a
feat: show more maintainers
vinnymac Jan 29, 2026
261239a
Merge branch 'main' into vt/show-more-maintainers
danielroe Jan 29, 2026
8868c6d
fix: add missing translations
vinnymac Jan 29, 2026
07b65fa
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 29, 2026
e44f16c
Update i18n/locales/en.json
vinnymac Jan 29, 2026
4d4a8e1
fix: replace less with fewer
vinnymac Jan 29, 2026
6ff5216
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion app/components/PackageMaintainers.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,25 @@ const {
const showAddOwner = shallowRef(false)
const newOwnerUsername = shallowRef('')
const isAdding = shallowRef(false)
const showAllMaintainers = shallowRef(false)

const DEFAULT_VISIBLE_MAINTAINERS = 5

// Show admin controls when connected (let npm CLI handle permission errors)
const canManageOwners = computed(() => isConnected.value)

// Computed for visible maintainers with show more/less support
const visibleMaintainers = computed(() => {
if (canManageOwners.value || showAllMaintainers.value) {
return maintainerAccess.value
}
return maintainerAccess.value.slice(0, DEFAULT_VISIBLE_MAINTAINERS)
})

const hiddenMaintainersCount = computed(() =>
Math.max(0, maintainerAccess.value.length - DEFAULT_VISIBLE_MAINTAINERS),
)

// Extract org name from scoped package
const orgName = computed(() => {
if (!props.packageName.startsWith('@')) return null
Expand Down Expand Up @@ -173,7 +188,7 @@ watch(
</h2>
<ul class="space-y-2 list-none m-0 p-0" :aria-label="$t('package.maintainers.list_label')">
<li
v-for="maintainer in maintainerAccess.slice(0, canManageOwners ? undefined : 5)"
v-for="maintainer in visibleMaintainers"
:key="maintainer.name ?? maintainer.email"
class="flex items-center justify-between gap-2"
>
Expand Down Expand Up @@ -214,6 +229,20 @@ watch(
</li>
</ul>

<!-- Show more/less toggle (only when not managing and there are hidden maintainers) -->
<button
v-if="!canManageOwners && hiddenMaintainersCount > 0"
type="button"
class="mt-2 text-xs text-fg-muted hover:text-fg transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 rounded"
@click="showAllMaintainers = !showAllMaintainers"
>
{{
showAllMaintainers
? $t('package.maintainers.show_less')
: $t('package.maintainers.show_more', { count: hiddenMaintainersCount })
}}
</button>

<!-- Add owner form (only when can manage) -->
<div v-if="canManageOwners" class="mt-3">
<div v-if="showAddOwner">
Expand Down
4 changes: 3 additions & 1 deletion i18n/locales/de-DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@
"username_placeholder": "Benutzername...",
"add_button": "Hinzufügen",
"cancel_add": "Owner-Hinzufügung abbrechen",
"add_owner": "+ Owner hinzufügen"
"add_owner": "+ Owner hinzufügen",
"show_more": "({count} weitere anzeigen)",
"show_less": "(weniger anzeigen)"
},
"downloads": {
"title": "Wöchentliche Downloads",
Expand Down
4 changes: 3 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,9 @@
"username_placeholder": "username...",
"add_button": "add",
"cancel_add": "Cancel adding owner",
"add_owner": "+ Add owner"
"add_owner": "+ Add owner",
"show_more": "(show {count} more)",
"show_less": "(show less)"
Comment thread
vinnymac marked this conversation as resolved.
Outdated
},
"downloads": {
"title": "Weekly Downloads",
Expand Down
4 changes: 3 additions & 1 deletion i18n/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@
"username_placeholder": "nombre de usuario...",
"add_button": "agregar",
"cancel_add": "Cancelar agregar propietario",
"add_owner": "+ Agregar propietario"
"add_owner": "+ Agregar propietario",
"show_more": "(mostrar {count} más)",
"show_less": "(mostrar menos)"
},
"downloads": {
"title": "Descargas Semanales",
Expand Down
4 changes: 3 additions & 1 deletion i18n/locales/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@
"username_placeholder": "nom d'utilisateur...",
"add_button": "ajouter",
"cancel_add": "Annuler l'ajout de propriétaire",
"add_owner": "+ Ajouter un propriétaire"
"add_owner": "+ Ajouter un propriétaire",
"show_more": "(afficher {count} de plus)",
"show_less": "(afficher moins)"
},
"downloads": {
"title": "Téléchargements hebdomadaires",
Expand Down
4 changes: 3 additions & 1 deletion i18n/locales/it-IT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@
"username_placeholder": "nome utente...",
"add_button": "aggiungi",
"cancel_add": "Cancella aggiunta proprietario",
"add_owner": "+ Aggiungi proprietario"
"add_owner": "+ Aggiungi proprietario",
"show_more": "(mostra altri {count})",
"show_less": "(mostra meno)"
},
"downloads": {
"title": "Downloads settimanali",
Expand Down
4 changes: 3 additions & 1 deletion i18n/locales/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@
"username_placeholder": "ユーザー名...",
"add_button": "追加",
"cancel_add": "オーナーの追加をキャンセル",
"add_owner": "+ オーナーを追加"
"add_owner": "+ オーナーを追加",
"show_more": "（他 {count} 個を表示）",
"show_less": "（折りたたむ）"
},
"downloads": {
"title": "週間ダウンロード数",
Expand Down
4 changes: 3 additions & 1 deletion i18n/locales/zh-CN.json
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@vinnymac vinnymac Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9romise I tried my best to get these right, let me know if you think the translations could be improved. I am better at romance langs haha

Copy link
Copy Markdown
Member

@9romise 9romise Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I think it's perfect! ❤️

Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@
"username_placeholder": "用户名...",
"add_button": "添加",
"cancel_add": "取消添加拥有者",
"add_owner": "+ 添加拥有者"
"add_owner": "+ 添加拥有者",
"show_more": "（显示另外 {count} 个）",
"show_less": "（收起）"
},
"downloads": {
"title": "每周下载量",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/de-DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@
"username_placeholder": "Benutzername...",
"add_button": "Hinzufügen",
"cancel_add": "Owner-Hinzufügung abbrechen",
"add_owner": "+ Owner hinzufügen"
"add_owner": "+ Owner hinzufügen",
"show_more": "({count} weitere anzeigen)",
"show_less": "(weniger anzeigen)"
},
"downloads": {
"title": "Wöchentliche Downloads",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,9 @@
"username_placeholder": "username...",
"add_button": "add",
"cancel_add": "Cancel adding owner",
"add_owner": "+ Add owner"
"add_owner": "+ Add owner",
"show_more": "(show {count} more)",
"show_less": "(show less)"
},
"downloads": {
"title": "Weekly Downloads",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/es-419.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@
"username_placeholder": "nombre de usuario...",
"add_button": "agregar",
"cancel_add": "Cancelar agregar propietario",
"add_owner": "+ Agregar propietario"
"add_owner": "+ Agregar propietario",
"show_more": "(mostrar {count} más)",
"show_less": "(mostrar menos)"
},
"downloads": {
"title": "Descargas Semanales",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/es-ES.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@
"username_placeholder": "nombre de usuario...",
"add_button": "agregar",
"cancel_add": "Cancelar agregar propietario",
"add_owner": "+ Agregar propietario"
"add_owner": "+ Agregar propietario",
"show_more": "(mostrar {count} más)",
"show_less": "(mostrar menos)"
},
"downloads": {
"title": "Descargas Semanales",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@
"username_placeholder": "nom d'utilisateur...",
"add_button": "ajouter",
"cancel_add": "Annuler l'ajout de propriétaire",
"add_owner": "+ Ajouter un propriétaire"
"add_owner": "+ Ajouter un propriétaire",
"show_more": "(afficher {count} de plus)",
"show_less": "(afficher moins)"
},
"downloads": {
"title": "Téléchargements hebdomadaires",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/it-IT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@
"username_placeholder": "nome utente...",
"add_button": "aggiungi",
"cancel_add": "Cancella aggiunta proprietario",
"add_owner": "+ Aggiungi proprietario"
"add_owner": "+ Aggiungi proprietario",
"show_more": "(mostra altri {count})",
"show_less": "(mostra meno)"
},
"downloads": {
"title": "Downloads settimanali",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@
"username_placeholder": "ユーザー名...",
"add_button": "追加",
"cancel_add": "オーナーの追加をキャンセル",
"add_owner": "+ オーナーを追加"
"add_owner": "+ オーナーを追加",
"show_more": "（他 {count} 個を表示）",
"show_less": "（折りたたむ）"
},
"downloads": {
"title": "週間ダウンロード数",
Expand Down
4 changes: 3 additions & 1 deletion lunaria/files/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@
"username_placeholder": "用户名...",
"add_button": "添加",
"cancel_add": "取消添加拥有者",
"add_owner": "+ 添加拥有者"
"add_owner": "+ 添加拥有者",
"show_more": "（显示另外 {count} 个）",
"show_less": "（收起）"
},
"downloads": {
"title": "每周下载量",
Expand Down