Skip to content

feat: add RTL support to PackageDownloadAnalytics #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Jan 29, 2026
Merged

feat: add RTL support to PackageDownloadAnalytics #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions app/components/PackageDownloadAnalytics.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ const config = computed(() => {
<div
class="flex items-center gap-2 px-2.5 py-1.75 bg-bg-subtle border border-border rounded-md focus-within:(border-border-hover ring-2 ring-accent/30)"
>
<span class="i-carbon-calendar w-4 h-4 text-fg-subtle shrink-0" aria-hidden="true" />
<span class="i-carbon:calendar w-4 h-4 text-fg-subtle shrink-0" aria-hidden="true" />
<input
id="startDate"
v-model="startDate"
Expand All @@ -639,7 +639,7 @@ const config = computed(() => {
<div
class="flex items-center gap-2 px-2.5 py-1.75 bg-bg-subtle border border-border rounded-md focus-within:(border-border-hover ring-2 ring-accent/30)"
>
<span class="i-carbon-calendar w-4 h-4 text-fg-subtle shrink-0" aria-hidden="true" />
<span class="i-carbon:calendar w-4 h-4 text-fg-subtle shrink-0" aria-hidden="true" />
<input
id="endDate"
v-model="endDate"
Expand All @@ -666,80 +666,80 @@ const config = computed(() => {
}
"
>
<span class="i-carbon-reset w-5 h-5 inline-block" aria-hidden="true" />
<span class="i-carbon:reset w-5 h-5 inline-block" aria-hidden="true" />
</button>
</div>
</div>

<ClientOnly v-if="inModal && chartData.dataset">
<VueUiXy :dataset="chartData.dataset" :config="config">
<template #menuIcon="{ isOpen }">
<span v-if="isOpen" class="i-carbon-close w-6 h-6" aria-hidden="true" />
<span v-else class="i-carbon-overflow-menu-vertical w-6 h-6" aria-hidden="true" />
<span v-if="isOpen" class="i-carbon:close w-6 h-6" aria-hidden="true" />
<span v-else class="i-carbon:overflow-menu-vertical w-6 h-6" aria-hidden="true" />
</template>
<template #optionCsv>
<span
class="i-carbon-csv w-6 h-6 text-fg-subtle"
class="i-carbon:csv w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
</template>
<template #optionImg>
<span
class="i-carbon-png w-6 h-6 text-fg-subtle"
class="i-carbon:png w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
</template>
<template #optionSvg>
<span
class="i-carbon-svg w-6 h-6 text-fg-subtle"
class="i-carbon:svg w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
</template>

<template #annotator-action-close>
<span
class="i-carbon-close w-6 h-6 text-fg-subtle"
class="i-carbon:close w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
</template>
<template #annotator-action-color="{ color }">
<span class="i-carbon-color-palette w-6 h-6" :style="{ color }" aria-hidden="true" />
<span class="i-carbon:color-palette w-6 h-6" :style="{ color }" aria-hidden="true" />
</template>
<template #annotator-action-undo>
<span
class="i-carbon-undo w-6 h-6 text-fg-subtle"
class="i-carbon:undo w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
</template>
<template #annotator-action-redo>
<span
class="i-carbon-redo w-6 h-6 text-fg-subtle"
class="i-carbon:redo w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
</template>
<template #annotator-action-delete>
<span
class="i-carbon-trash-can w-6 h-6 text-fg-subtle"
class="i-carbon:trash-can w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
</template>
<template #optionAnnotator="{ isAnnotator }">
<span
v-if="isAnnotator"
class="i-carbon-edit-off w-6 h-6 text-fg-subtle"
class="i-carbon:edit-off w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
<span
v-else
class="i-carbon-edit w-6 h-6 text-fg-subtle"
class="i-carbon:edit w-6 h-6 text-fg-subtle"
style="pointer-events: none"
aria-hidden="true"
/>
Expand All @@ -762,7 +762,7 @@ const config = computed(() => {
v-if="pending"
role="status"
aria-live="polite"
class="absolute top-1/2 left-1/2 -translate-x-1/2 -translate-y-1/2 text-xs text-fg-subtle font-mono bg-bg/70 backdrop-blur px-3 py-2 rounded-md border border-border"
class="absolute top-1/2 inset-is-1/2 -translate-x-1/2 -translate-y-1/2 text-xs text-fg-subtle font-mono bg-bg/70 backdrop-blur px-3 py-2 rounded-md border border-border"
>
{{ $t('package.downloads.loading') }}
</div>
Expand Down
Loading