Skip to content

feat: add RTL support to PackageVulnerabilityTree #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Jan 29, 2026
Merged

feat: add RTL support to PackageVulnerabilityTree #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions app/components/PackageVulnerabilityTree.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ const summaryText = computed(() => {
// Styling for each depth level - using accessible colors for both themes
const depthStyles = {
root: {
bg: 'bg-amber-500/5 border-l-2 border-l-amber-600',
bg: 'bg-amber-500/5 border-is-2 border-is-amber-600',
text: 'text-fg',
},
direct: {
bg: 'bg-amber-500/5 border-l-2 border-l-amber-500',
bg: 'bg-amber-500/5 border-is-2 border-is-amber-500',
text: 'text-fg-muted',
},
transitive: {
bg: 'bg-amber-500/5 border-l-2 border-l-amber-400',
bg: 'bg-amber-500/5 border-is-2 border-is-amber-400',
text: 'text-fg-muted',
},
} as const
Expand All @@ -72,13 +72,13 @@ function getDepthStyle(depth: string | undefined) {
<!-- Header -->
<button
type="button"
class="w-full flex items-center justify-between gap-3 px-4 py-3 text-left transition-colors duration-200 hover:bg-white/5 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-fg/50"
class="w-full flex items-center justify-between gap-3 px-4 py-3 text-start transition-colors duration-200 hover:bg-white/5 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-fg/50"
:aria-expanded="isExpanded"
aria-controls="vuln-tree-details"
@click="isExpanded = !isExpanded"
>
<div class="flex items-center gap-2 min-w-0">
<span class="i-carbon-warning-alt w-4 h-4 shrink-0" aria-hidden="true" />
<span class="i-carbon:warning-alt w-4 h-4 shrink-0" aria-hidden="true" />
<span class="font-mono text-sm font-medium truncate">
{{
$t(
Expand All @@ -96,7 +96,7 @@ function getDepthStyle(depth: string | undefined) {
<div class="flex items-center gap-2 shrink-0">
<span class="text-xs opacity-80 hidden sm:inline">{{ summaryText }}</span>
<span
class="i-carbon-chevron-down w-4 h-4 transition-transform duration-200"
class="i-carbon:chevron-down w-4 h-4 transition-transform duration-200"
:class="{ 'rotate-180': isExpanded }"
aria-hidden="true"
/>
Expand Down Expand Up @@ -181,7 +181,7 @@ function getDepthStyle(depth: string | undefined) {
v-if="vulnTree!.failedQueries"
class="px-4 py-2 text-xs text-fg-subtle border-t border-border flex items-center gap-2"
>
<span class="i-carbon-warning w-3 h-3" aria-hidden="true" />
<span class="i-carbon:warning w-3 h-3" aria-hidden="true" />
<span>{{ $t('package.vulnerabilities.packages_failed', vulnTree!.failedQueries) }}</span>
</div>
</div>
Expand All @@ -196,7 +196,7 @@ function getDepthStyle(depth: string | undefined) {
<section v-else-if="status === 'error'" aria-labelledby="vuln-tree-error">
<div class="rounded-lg border border-border bg-bg-subtle px-4 py-3">
<div class="flex items-center gap-2">
<span class="i-carbon-warning w-4 h-4 text-fg-subtle" aria-hidden="true" />
<span class="i-carbon:warning w-4 h-4 text-fg-subtle" aria-hidden="true" />
<span class="text-sm text-fg-muted">
{{ $t('package.vulnerabilities.scan_failed') }}
</span>
Expand Down
Loading