Skip to content

feat: add RTL support to VersionSelector #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Jan 29, 2026
+8 −8
Merged

feat: add RTL support to VersionSelector #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions app/components/VersionSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ watch(
latest
</span>
<span
class="i-carbon-chevron-down w-3.5 h-3.5 transition-[transform] duration-200 motion-reduce:transition-none"
class="i-carbon:chevron-down w-3.5 h-3.5 transition-[transform] duration-200 motion-reduce:transition-none"
:class="{ 'rotate-180': isOpen }"
aria-hidden="true"
/>
Expand All @@ -507,7 +507,7 @@ watch(
:aria-activedescendant="
focusedIndex >= 0 ? `version-${flatItems[focusedIndex]?.version?.version}` : undefined
"
class="absolute top-full left-0 mt-2 min-w-[220px] bg-bg-elevated border border-border rounded-lg shadow-lg z-50 py-1 max-h-[400px] overflow-y-auto overscroll-contain focus-visible:outline-none"
class="absolute top-full inset-is-0 mt-2 min-w-[220px] bg-bg-elevated border border-border rounded-lg shadow-lg z-50 py-1 max-h-[400px] overflow-y-auto overscroll-contain focus-visible:outline-none"
@keydown="handleListboxKeydown"
>
<!-- Version groups -->
Expand Down Expand Up @@ -541,13 +541,13 @@ watch(
>
<span
v-if="group.isLoading"
class="i-carbon-rotate-180 w-3 h-3 motion-safe:animate-spin"
class="i-carbon:rotate-180 w-3 h-3 motion-safe:animate-spin"
aria-hidden="true"
/>
<span
v-else
class="w-3 h-3 transition-transform duration-200"
:class="group.isExpanded ? 'i-carbon-chevron-down' : 'i-carbon-chevron-right'"
class="w-3 h-3 transition-transform duration-200 rtl-flip"
:class="group.isExpanded ? 'i:carbon:chevron-down' : 'i-carbon:chevron-right'"
aria-hidden="true"
/>
</button>
Expand Down Expand Up @@ -582,7 +582,7 @@ watch(
<!-- Expanded versions -->
<div
v-if="group.isExpanded && group.versions.length > 1"
class="ml-6 border-l border-border"
class="ms-6 border-is border-border"
>
<template v-for="(v, vIndex) in group.versions.slice(1)" :key="v.version">
<NuxtLink
Expand All @@ -595,7 +595,7 @@ watch(
flatItems[focusedIndex]?.type === 'version' &&
flatItems[focusedIndex]?.version?.version === v.version
"
class="flex items-center justify-between gap-2 pl-4 pr-3 py-1.5 text-xs font-mono hover:bg-bg-muted transition-[color,background-color] focus-visible:outline-none"
class="flex items-center justify-between gap-2 ps-4 pe-3 py-1.5 text-xs font-mono hover:bg-bg-muted transition-[color,background-color] focus-visible:outline-none"
:class="[
v.isCurrent ? 'text-fg bg-bg-muted' : 'text-fg-subtle',
flatItems[focusedIndex]?.version?.version === v.version ? 'bg-bg-muted' : '',
Expand Down
2 changes: 1 addition & 1 deletion test/nuxt/components/VersionSelector.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ describe('VersionSelector', () => {

// Should show loading spinner (motion-safe:animate-spin is applied)
await vi.waitFor(() => {
const spinner = component.find('.i-carbon-rotate-180')
const spinner = component.find('.i-carbon\\:rotate-180')
expect(spinner.exists()).toBe(true)
})

Expand Down
Loading