Skip to content

feat: add RTL support to settings page #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Jan 29, 2026
Merged

feat: add RTL support to settings page #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions app/pages/settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ defineOgImageComponent('Default', {
class="inline-flex items-center gap-2 font-mono text-sm text-fg-muted hover:text-fg transition-colors duration-200 rounded focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 shrink-0"
@click="router.back()"
>
<span class="i-carbon-arrow-left w-4 h-4" aria-hidden="true" />
<span class="i-carbon:arrow-left rtl-flip w-4 h-4" aria-hidden="true" />
<span class="hidden sm:inline">{{ $t('nav.back') }}</span>
</button>
</div>
Expand Down Expand Up @@ -106,7 +106,7 @@ defineOgImageComponent('Default', {
:aria-checked="settings.relativeDates"
@click="settings.relativeDates = !settings.relativeDates"
>
<span class="text-sm text-fg font-medium text-left">
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.relative_dates') }}
</span>
<span
Expand All @@ -116,9 +116,7 @@ defineOgImageComponent('Default', {
>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="
settings.relativeDates ? 'translate-x-5 bg-bg' : 'translate-x-0 bg-fg-muted'
"
:class="settings.relativeDates ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
Expand All @@ -139,7 +137,7 @@ defineOgImageComponent('Default', {
:aria-checked="settings.includeTypesInInstall"
@click="settings.includeTypesInInstall = !settings.includeTypesInInstall"
>
<span class="text-sm text-fg font-medium text-left">
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.include_types') }}
</span>
<span
Expand All @@ -151,11 +149,7 @@ defineOgImageComponent('Default', {
>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="
settings.includeTypesInInstall
? 'translate-x-5 bg-bg'
: 'translate-x-0 bg-fg-muted'
"
:class="settings.includeTypesInInstall ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
Expand All @@ -176,7 +170,7 @@ defineOgImageComponent('Default', {
:aria-checked="settings.hidePlatformPackages"
@click="settings.hidePlatformPackages = !settings.hidePlatformPackages"
>
<span class="text-sm text-fg font-medium text-left">
<span class="text-sm text-fg font-medium text-start">
{{ $t('settings.hide_platform_packages') }}
</span>
<span
Expand All @@ -188,11 +182,7 @@ defineOgImageComponent('Default', {
>
<span
class="pointer-events-none inline-block h-5 w-5 rounded-full shadow-sm ring-0 transition-transform duration-200 ease-in-out motion-reduce:transition-none"
:class="
settings.hidePlatformPackages
? 'translate-x-5 bg-bg'
: 'translate-x-0 bg-fg-muted'
"
:class="settings.hidePlatformPackages ? 'bg-bg' : 'bg-fg-muted'"
/>
</span>
</button>
Expand Down Expand Up @@ -246,7 +236,7 @@ defineOgImageComponent('Default', {
rel="noopener noreferrer"
class="inline-flex items-center gap-2 text-sm text-fg-muted hover:text-fg transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 rounded"
>
<span class="i-carbon-logo-github w-4 h-4" aria-hidden="true" />
<span class="i-carbon:logo-github w-4 h-4" aria-hidden="true" />
{{ $t('settings.help_translate') }}
</a>
</template>
Expand All @@ -256,3 +246,15 @@ defineOgImageComponent('Default', {
</article>
</main>
</template>

<style scoped>
button[aria-checked='false'] > span:last-of-type > span {
translate: 0;
}
button[aria-checked='true'] > span:last-of-type > span {
translate: calc(100%);
}
html[dir='rtl'] button[aria-checked='true'] > span:last-of-type > span {
translate: calc(-100%);
}
</style>
Loading