fix: search field losing focus after transition#399
Closed
Flo0806 wants to merge 2 commits intonpmx-dev:mainfrom
Closed
fix: search field losing focus after transition#399Flo0806 wants to merge 2 commits intonpmx-dev:mainfrom
Flo0806 wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
danielroe
approved these changes
Jan 30, 2026
Member
|
we already test focus in the browser tests - would you see why it's failing, and add a test case if applicable? 🙏 |
Contributor
Author
|
The test check the focus on the settings page only. The issue happened while the route changing from home - settings + running transition. I added a new test which is failing for me without the fix. |
danielroe
added a commit
that referenced
this pull request
Jan 31, 2026
Co-authored-by: Florian Heuberger <fh@flogersoft.de> Co-authored-by: cullophid <andreas.moller@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #397
add a watcher to handle visible state after transition correctly and set focus