Skip to content

feat: add roving tabindex + tabpanels for pm tabs#401

Closed
damevin wants to merge 1 commit intonpmx-dev:mainfrom
damevin:feat/improve-tabs-navigation
Closed

feat: add roving tabindex + tabpanels for pm tabs#401
damevin wants to merge 1 commit intonpmx-dev:mainfrom
damevin:feat/improve-tabs-navigation

Conversation

@damevin
Copy link
Copy Markdown
Contributor

@damevin damevin commented Jan 30, 2026

What this PR do and why ?

This PR improves the package manager tabs accessibility by implementing proper roving
tabindex behavior and correct ARIA tab/tabpanel wiring. It avoids duplicated DOM for
panels while keeping the expected keyboard navigation.

30012026-r4BKf2Is

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 30, 2026 9:20am
npmx.dev Ready Ready Preview, Comment Jan 30, 2026 9:20am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Jan 30, 2026 9:20am

Request Review

@damevin damevin changed the title feat(a11y): add roving tabindex + tabpanels for pm tabs feat: add roving tabindex + tabpanels for pm tabs Jan 30, 2026
@github-actions
Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant