Skip to content

style: replace physical RTL classes with logical ones#404

Merged
danielroe merged 3 commits intonpmx-dev:mainfrom
shuuji3:fix/replace-non-rtl-classes
Jan 30, 2026
Merged

style: replace physical RTL classes with logical ones#404
danielroe merged 3 commits intonpmx-dev:mainfrom
shuuji3:fix/replace-non-rtl-classes

Conversation

@shuuji3
Copy link
Copy Markdown
Member

@shuuji3 shuuji3 commented Jan 30, 2026

  • replace remaining physical directions (left/right, pl-/pr-, etc.) with logical directions (start/end, ps-/pe-, etc.) in various components
  • update CONTRIBUTING.md - there is one wrong example: rounded-l-5 should be rounded-is-5 but it suggested replacing with rounded-ie-5
  • remove redundant css in main.css - .skip-link { inset-inline-start: 0 } should cover both cases

@userquin Can you take a look? (after getting enough sleep 😴) I saw your review comments on #391 and found many remaining left/right classes across the repository.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 30, 2026 10:49am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jan 30, 2026 10:49am
npmx-lunaria Ignored Ignored Jan 30, 2026 10:49am

Request Review

@danielroe danielroe added this pull request to the merge queue Jan 30, 2026
Merged via the queue into npmx-dev:main with commit d5b7637 Jan 30, 2026
13 checks passed
@shuuji3 shuuji3 deleted the fix/replace-non-rtl-classes branch January 30, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants