Skip to content

fix(i18n): update i18n logic#434

Merged
danielroe merged 4 commits intonpmx-dev:mainfrom
userquin:fix-i18n-logic
Jan 30, 2026
Merged

fix(i18n): update i18n logic#434
danielroe merged 4 commits intonpmx-dev:mainfrom
userquin:fix-i18n-logic

Conversation

@userquin
Copy link
Copy Markdown
Member

@userquin userquin commented Jan 30, 2026

This PR includes:

  • simplified logic for locales at setting page including lang in the select options
  • change locales type at config/i18n.ts
  • fix arabic locale, it is wrong, we need ar at locales entry in config/i18n.ts module
  • config/i18n.ts now exports correct translation files (I'm checking it, since we cannot buuild lunaria status.json without files tracked => ar.json removed and ar-EG.json added
  • update lunaria/files

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 30, 2026 8:02pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jan 30, 2026 8:02pm
npmx-lunaria Ignored Ignored Jan 30, 2026 8:02pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/ar-EG.json Localization added, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Comment thread i18n/locales/en.json Outdated
@userquin userquin marked this pull request as draft January 30, 2026 18:25
@userquin userquin changed the title fix: update i18n logic fix(i18n): update i18n logic Jan 30, 2026
@userquin
Copy link
Copy Markdown
Member Author

userquin commented Jan 30, 2026

REOPENED: I'm going to send a new PR...

@userquin userquin closed this Jan 30, 2026
@userquin userquin deleted the fix-i18n-logic branch January 30, 2026 18:54
@userquin userquin restored the fix-i18n-logic branch January 30, 2026 19:08
@userquin userquin reopened this Jan 30, 2026
@userquin userquin marked this pull request as ready for review January 30, 2026 19:09
@danielroe danielroe added this pull request to the merge queue Jan 30, 2026
Merged via the queue into npmx-dev:main with commit d171b38 Jan 30, 2026
13 checks passed
@userquin userquin deleted the fix-i18n-logic branch January 30, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants