fix: remove disabledReason to avoid UI issues when not in english#518
Closed
whitep4nth3r wants to merge 2 commits intonpmx-dev:mainfrom
Closed
fix: remove disabledReason to avoid UI issues when not in english#518whitep4nth3r wants to merge 2 commits intonpmx-dev:mainfrom
whitep4nth3r wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
Contributor
Author
|
I'm an idiot. Disregard this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could potentially fix #513 (comment)
I cleaned up everywhere else that used
disabledReason.Instead of the "coming soon" in the dropdown, we could consider adding a message in the UI that more options are coming soon.
That being said, is it wrong to consider that the people using this tool will most likely understand why the options are disabled anyway?