Skip to content

fix: ignore shortcuts on text input #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 1, 2026
Merged

fix: ignore shortcuts on text input #547

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23c580e
fix: ignore shortcuts on text input
shamilkotta Jan 31, 2026
ab28b00
Merge branch 'main' into fix/ignore-shortcuts
serhalp Feb 1, 2026
89c5825
refactor: extract duplicated isEditableElement util
serhalp Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion app/pages/[...package].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,10 @@ useSeoMeta({
onKeyStroke(
'.',
e => {
const target = e.target as HTMLElement
if (target.tagName === 'INPUT' || target.tagName === 'TEXTAREA' || target.isContentEditable) {
return
}
if (pkg.value && displayVersion.value) {
e.preventDefault()
navigateTo({
Expand All @@ -345,6 +349,10 @@ onKeyStroke(
onKeyStroke(
'd',
e => {
const target = e.target as HTMLElement
if (target.tagName === 'INPUT' || target.tagName === 'TEXTAREA' || target.isContentEditable) {
return
}
if (docsLink.value) {
e.preventDefault()
navigateTo(docsLink.value)
Expand All @@ -353,7 +361,11 @@ onKeyStroke(
{ dedupe: true },
)

onKeyStroke('c', () => {
onKeyStroke('c', e => {
const target = e.target as HTMLElement
if (target.tagName === 'INPUT' || target.tagName === 'TEXTAREA' || target.isContentEditable) {
Comment thread
serhalp marked this conversation as resolved.
Outdated
return
}
if (pkg.value) {
router.push({ path: '/compare', query: { packages: pkg.value.name } })
}
Expand Down
Loading