Fix: updated column is balanced with package links#57
Merged
danielroe merged 2 commits intonpmx-dev:mainfrom Jan 25, 2026
Merged
Conversation
|
@jhroemer is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
jhroemer
commented
Jan 25, 2026
| </div> | ||
|
|
||
| <div v-if="getDependencyCount(displayVersion) > 0" class="space-y-1"> | ||
| <div class="space-y-1"> |
Contributor
Author
There was a problem hiding this comment.
Arguably this could be its own change, as a precursor for right-aligning the last column (right aligning without showing deps looks pretty bad). Happy to break it up into separate PR's if you want.
Contributor
Author
|
Maybe this is a dumb idea, but we should almost add some kind of extra highlighting in the |
Member
|
oops - need to fix mobile alignment
|
Contributor
Author
Ah shit, that’s my bad, sorry! |
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR balances the license/downloads/deps etc. row somewhat with the package links row beneath it, by right-aligning the last column. Also, currently if there are no dependencies, the deps column is hidden, causing
install sizeandupdatedto shift a position to the left. I think it's worth showingdepseven if the value is 0 - a user might be looking for the section, not finding it, and not realizing that this is because the package has none. Showing it, even if the value is 0, makes this very clear. The npmgraph link should probably be hidden though.Before:
After:
Again, just a proposal :-)