chore: convert chart modal to modal route#615
Closed
iiio2 wants to merge 2 commits intonpmx-dev:mainfrom
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Member
|
this may require updating after #522 was merged 🙏 |
iiio2
force-pushed
the
chore/convert-chartmodal
branch
from
df858b3 to
f8fee4f
Compare
Contributor
Author
|
@danielroe , I think I've done it. |
Member
|
looking, this isn't a modal route - it's just another page. the idea of a modal route is to render the modal if you click the button, but to change the url so on hard reload it reloads a full-screen page with the same content. |
Contributor
|
Ah I think this is also resolved unfortunately - let me know if I'm wrong! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #516