fix: add options to prevent ssr mismatch on settings#622
Closed
damevin wants to merge 3 commits intonpmx-dev:mainfrom
Closed
fix: add options to prevent ssr mismatch on settings#622damevin wants to merge 3 commits intonpmx-dev:mainfrom
damevin wants to merge 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Member
|
I can't actually reproduce this on npmx.dev |
Contributor
Author
|
I think the bug was fixed by this #560 since we now have server/client component I've tested yesterday night lol, but it's looks good now |
Member
|
moving too fast! ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR do and why ?
Fixes a settings persistence issue where toggles could reset when opening a package page in a new tab or reloading. We now initialize settings after mount without overwriting existing localStorage, and add an E2E test to ensure settings persist across tabs and reloads.
How to setup and validate locally
/settings, toggle any setting/nuxtin a new tab/nuxt-> toggles stay as setpnpm test:browser -- tests/settings.spec.tsRelated to #536